Skip to content

Commit 1458971

Browse files
ci: ensures release touches at least one file (#19)
Signed-off-by: Adrian Cole <[email protected]>
1 parent d99c588 commit 1458971

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

build-bin/helm/helm_prepare

+6-5
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
#
1515

1616
# This script prepares the helm chart for a release by updating the versions in the chart file.
17+
#
18+
# Note: helm/chart-releaser-action silently fails if there is no change made here.
19+
# Hence, we should never update the chart version manually.
1720

1821
trigger_tag=${1?trigger_tag is required. Ex release-1.2.3}
1922
release_version=$(build-bin/git/version_from_trigger_tag release- ${trigger_tag})
@@ -39,9 +42,7 @@ sh -c "sed -i 's/appVersion\:\s[0-9.]\+/appVersion\: ${latest_app_version}/g' ./
3942
sh -c "sed -i 's/version\:\s[0-9.]\+/version\: ${release_version}/g' ./charts/zipkin/Chart.yaml"
4043

4144
# Commit changes to ./charts/zipkin/Chart.yaml
42-
git add ./charts/zipkin/Chart.yaml
45+
git add ./charts/zipkin/Chart.yaml && git commit -m "release: zipkin-${release_version}"
4346

44-
if git commit -m "release: updates for ${release_version}"; then
45-
# Push the changes in ./charts/zipkin/Chart.yaml to the release branch
46-
git push origin ${release_branch}
47-
fi
47+
# Push the changes in ./charts/zipkin/Chart.yaml to the release branch
48+
git push origin ${release_branch}

charts/zipkin/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ appVersion: 3.0.6
1414
name: zipkin
1515
description: A Zipkin helm chart for kubernetes
1616
type: application
17-
version: 0.2.0
17+
version: 0.1.2 # chart version maintained by release automation
1818
maintainers:
1919
- name: openzipkin
2020

0 commit comments

Comments
 (0)