Skip to content

Commit 990245f

Browse files
authored
Configure repository.directory for monorepo packages (#471)
Summary: Configure each package's package.json#repository.directory property to properly reflect the location of the package within the repository. This is the standard configuration value for deep-linking into a package's directory within a monorepo. npm RFC: https://github.com/npm/rfcs/blob/latest/implemented/0010-monorepo-subdirectory-declaration.md This will ensure the packages' pages on npmjs.org will link to the correct directory. Also, _eventually_, it will ensure the npm repo command opens to the correct location: npm/cli#163 Lastly, this is _required_ for monorepo packages to be successfully published to the GitHub Package Registry (if that is ever considered in the future). https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-npm-for-use-with-github-packages#publishing-multiple-packages-to-the-same-repository
1 parent 5fdc3e0 commit 990245f

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

packages/datafile-manager/package.json

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
"name": "@optimizely/js-sdk-datafile-manager",
33
"version": "0.5.0",
44
"description": "Optimizely Full Stack Datafile Manager",
5+
"repository": {
6+
"type": "git",
7+
"url": "git+https://github.com/optimizely/javascript-sdk.git",
8+
"directory": "packages/datafile-manager"
9+
},
510
"license": "Apache-2.0",
611
"engines": {
712
"node": ">=8.0.0"

packages/event-processor/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
},
2626
"repository": {
2727
"type": "git",
28-
"url": "git+https://github.com/optimizely/javascript-sdk.git"
28+
"url": "git+https://github.com/optimizely/javascript-sdk.git",
29+
"directory": "packages/event-processor"
2930
},
3031
"keywords": [
3132
"optimizely"

packages/logging/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
},
2626
"repository": {
2727
"type": "git",
28-
"url": "git+https://github.com/optimizely/javascript-sdk.git"
28+
"url": "git+https://github.com/optimizely/javascript-sdk.git",
29+
"directory": "packages/logging"
2930
},
3031
"keywords": [
3132
"optimizely"

packages/optimizely-sdk/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
},
2222
"repository": {
2323
"type": "git",
24-
"url": "git+https://github.com/optimizely/javascript-sdk.git"
24+
"url": "git+https://github.com/optimizely/javascript-sdk.git",
25+
"directory": "packages/optimizely-sdk"
2526
},
2627
"license": "Apache-2.0",
2728
"engines": {

packages/utils/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
},
2626
"repository": {
2727
"type": "git",
28-
"url": "git+https://github.com/optimizely/javascript-sdk.git"
28+
"url": "git+https://github.com/optimizely/javascript-sdk.git",
29+
"directory": "packages/utils"
2930
},
3031
"keywords": [
3132
"optimizely"

0 commit comments

Comments
 (0)