Skip to content

Commit 1d8dbda

Browse files
committedSep 17, 2018
[win] Fix some warnings
1 parent a0dceb1 commit 1d8dbda

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed
 

Diff for: ‎external/wintoast/src/wintoastlib.h

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ namespace WinToastLib {
3535
ApplicationHidden = ToastDismissalReason::ToastDismissalReason_ApplicationHidden,
3636
TimedOut = ToastDismissalReason::ToastDismissalReason_TimedOut
3737
};
38+
virtual ~IWinToastHandler() = default;
3839
virtual void toastActivated() const = 0;
3940
virtual void toastActivated(int actionIndex) const = 0;
4041
virtual void toastDismissed(WinToastDismissalReason state) const = 0;

Diff for: ‎src/native/win/qgswinnative.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void QgsWinNative::openFileExplorerAndSelectFile( const QString &path )
7070
const QString nativePath = QDir::toNativeSeparators( path );
7171

7272
wchar_t *pathArray = new wchar_t[static_cast< uint>( nativePath.length() + 1 )];
73-
nativePath.toWCharArray(pathArray);
73+
nativePath.toWCharArray( pathArray );
7474
pathArray[nativePath.length()] = 0;
7575

7676
ITEMIDLIST *pidl = ILCreateFromPathW( pathArray );
@@ -124,7 +124,7 @@ class NotificationHandler : public WinToastLib::IWinToastHandler
124124

125125
void toastActivated( int ) const override {}
126126

127-
void toastFailed() const
127+
void toastFailed() const override
128128
{
129129
qWarning() << "Error showing notification";
130130
}

Diff for: ‎tests/src/python/test_qgsprocessinginplace.py

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727

2828
class ConsoleFeedBack(QgsProcessingFeedback):
29+
2930
def reportError(self, error, fatalError=False):
3031
print(error)
3132

0 commit comments

Comments
 (0)
Please sign in to comment.