call v8 function directly (fixes 2 of 3 failing tests)

Dane Springmeyer · Dane Springmeyer · commit 572fd278f035 · 2016-03-31T17:23:04.000-07:00
diff --git a/src/handler.cpp b/src/handler.cpp
@@ -159,15 +159,14 @@ namespace node_osmium {
             return;
         }
         v8::Local<v8::Value> argv[1] = { new_external<TWrapped>(entity) };
-        Nan::MakeCallback(Nan::GetCurrentContext()->Global(), Nan::New(function), 1, argv);
+        Nan::New(function)->Call(Nan::GetCurrentContext()->Global(), 1, argv);
     }
 
     void call_callback(const Nan::Persistent<v8::Function>& function) {
         if (function.IsEmpty()) {
             return;
         }
-
-        Nan::MakeCallback(Nan::GetCurrentContext()->Global(), Nan::New(function), 0, nullptr);
+        Nan::New(function)->Call(Nan::GetCurrentContext()->Global(), 0, nullptr);
     }
 
     void JSHandler::dispatch_entity(const osmium::OSMEntity& entity) const {

Original file line number	Diff line number	Diff line change
`@@ -159,15 +159,14 @@ namespace node_osmium {`
`159`	`159`	`return;`
`160`	`160`	`}`
`161`	`161`	`v8::Local<v8::Value> argv[1] = { new_external<TWrapped>(entity) };`
`162`		`- Nan::MakeCallback(Nan::GetCurrentContext()->Global(), Nan::New(function), 1, argv);`
	`162`	`+ Nan::New(function)->Call(Nan::GetCurrentContext()->Global(), 1, argv);`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`void call_callback(const Nan::Persistent<v8::Function>& function) {`
`166`	`166`	`if (function.IsEmpty()) {`
`167`	`167`	`return;`
`168`	`168`	`}`
`169`		`-`
`170`		`- Nan::MakeCallback(Nan::GetCurrentContext()->Global(), Nan::New(function), 0, nullptr);`
	`169`	`+ Nan::New(function)->Call(Nan::GetCurrentContext()->Global(), 0, nullptr);`
`171`	`170`	`}`
`172`	`171`
`173`	`172`	`void JSHandler::dispatch_entity(const osmium::OSMEntity& entity) const {`