Skip to content

Commit ab292d9

Browse files
committed
analyzer: Remove peerDependencies from NPM / Yarn test assets
ORT does not support `peerDependencies` yet [1]. That is mostly because handling of peer dependencies varies with NPM versions: Some versions do install them by default, some do not [2]. This results in ORT's functional tests to fail depending on the NPM version, and as it turns out, they would fail with the NPM version 7 currently used in ORT's `Dockerfile`. However, tests succeed on Azure CI which uses NPM 6. Avoid that inconsistency by simply not using peer dependencies at all for testing for now. [1]: #95 [2]: https://nodejs.org/en/blog/npm/peer-dependencies#using-peer-dependencies Signed-off-by: Sebastian Schuberth <[email protected]>
1 parent 9ebfa9c commit ab292d9

File tree

5 files changed

+0
-15
lines changed

5 files changed

+0
-15
lines changed

analyzer/src/funTest/assets/projects/synthetic/npm/no-lockfile/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
"devDependencies": {
1616
"cson": "~4.1.0"
1717
},
18-
"peerDependencies": {
19-
"tea": "0.x"
20-
},
2118
"optionalDependencies": {
2219
"promise": "~7.3.1"
2320
}

analyzer/src/funTest/assets/projects/synthetic/npm/node-modules/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
"devDependencies": {
1818
"cson": "~4.1.0"
1919
},
20-
"peerDependencies": {
21-
"tea": "0.x"
22-
},
2320
"optionalDependencies": {
2421
"promise": "~7.3.1"
2522
}

analyzer/src/funTest/assets/projects/synthetic/npm/package-lock/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
"devDependencies": {
1818
"cson": "~4.1.0"
1919
},
20-
"peerDependencies": {
21-
"tea": "0.x"
22-
},
2320
"optionalDependencies": {
2421
"promise": "~7.3.1"
2522
}

analyzer/src/funTest/assets/projects/synthetic/npm/shrinkwrap/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
"devDependencies": {
2222
"cson": "~4.1.0"
2323
},
24-
"peerDependencies": {
25-
"tea": "0.x"
26-
},
2724
"optionalDependencies": {
2825
"promise": "~7.3.1"
2926
}

analyzer/src/funTest/assets/projects/synthetic/yarn/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
"devDependencies": {
1616
"cson": "~4.1.0"
1717
},
18-
"peerDependencies": {
19-
"tea": "0.x"
20-
},
2118
"optionalDependencies": {
2219
"promise": "~7.3.1"
2320
}

0 commit comments

Comments
 (0)