DEPR: pandas.core.index #30193
DEPR: pandas.core.index #30193
Conversation
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -490,7 +490,7 @@ Deprecations | |||
| - :func:`eval` keyword argument "truediv" is deprecated and will be removed in a future version (:issue:`29812`) | |||
| - :meth:`Categorical.take_nd` is deprecated, use :meth:`Categorical.take` instead (:issue:`27745`) | |||
| - The parameter ``numeric_only`` of :meth:`Categorical.min` and :meth:`Categorical.max` is deprecated and replaced with ``skipna`` (:issue:`25303`) | |||
| - | |||
| - :module:`pandas.core.index` has been deprecated and will be removed in a future version, use :module:`pandas.core.indexes.api` instead (:issue:`19711`) | |||
There was a problem hiding this comment.
This should not be the recommended alternative, I think? (nothing in pandas.core should be public)
I think @jreback's suggestion to use pandas.core.indexes was for internal replacement
There was a problem hiding this comment.
so remove all of this note or just the part about using indexes.api?
There was a problem hiding this comment.
the docbuild doesnt like ":module:" here, what is the appropriate label?
There was a problem hiding this comment.
Nothing, just use double backticks for code. The :obj: things are only to link to something (like an API page), but for a module we have nothing to link to.
There was a problem hiding this comment.
so remove all of this note or just the part about using indexes.api?
You can mention that all public classes (eg the several index classes) are available from the top-level namespace.
| warnings.warn( | ||
| "pandas.core.index is deprecated and will be removed in a future version. " | ||
| "Use pandas.core.indexes.api instead.", | ||
| FutureWarning, |
There was a problem hiding this comment.
Let's start with a DeprecationWarning?
There was a problem hiding this comment.
this has been around forever
let’s just be loud about it (and it had been deprecation via documentation. forever)
There was a problem hiding this comment.
OK, opened an issue about it at fastparquet: dask/fastparquet#470
pandas/core/index.py
Outdated
|
|
||
| warnings.warn( | ||
| "pandas.core.index is deprecated and will be removed in a future version. " | ||
| "Use pandas.core.indexes.api instead.", |
There was a problem hiding this comment.
Can you update this with the same as what you put in the whatsnew? (that is is available from the top-level namespace)
| @@ -453,7 +453,7 @@ See :ref:`install.dependencies` and :ref:`install.optional_dependencies` for mor | |||
| Other API changes | |||
| ^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - Bumpded the minimum supported version of ``s3fs`` from 0.0.8 to 0.3.0 (:issue:`28616`) | |||
| - Bumped the minimum supported version of ``s3fs`` from 0.0.8 to 0.3.0 (:issue:`28616`) | |||
There was a problem hiding this comment.
can you update the section that has our min supported version (in the whatsnew) (don't really need this issue line in that case)
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff