Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pants should be able to tell if its launcher script is up-to-date #17581

Open
chrisjrn opened this issue Nov 18, 2022 · 2 comments
Open

Pants should be able to tell if its launcher script is up-to-date #17581

chrisjrn opened this issue Nov 18, 2022 · 2 comments

Comments

@chrisjrn
Copy link
Contributor

Watching the back-and-forth on #17563, we're running into an issue with the VERSION file again. We didn't change it in the first place because the path to the VERSION file is hardcoded into the launcher script.

Moving the VERSION file has been assessed to have minimal impact, because it only affects users of PANTS_FROM_SHA, however, with future changes (such as adding new distribution formats), it would be useful to alert users to the launcher script changing, in case the breakage is more severe.

@thejcannon
Copy link
Member

Just hardcoding a "version" into the launcher and then the latest "version" in pants itself might be sufficient.

Incorrect for older pants versions, but dead simple

@huonw
Copy link
Contributor

huonw commented Nov 27, 2022

After pantsbuild/setup#129, the setup script now has SCRIPT_VERSION, but this isn't pushed into the pants invocation (and presumably should be propagated with a more specific name like PANTS_BOOTSTRAP_SCRIPT_VERSION or something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants