Skip to content

Missing git commit in version #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BulatSaif opened this issue Feb 2, 2024 · 3 comments
Open

Missing git commit in version #189

BulatSaif opened this issue Feb 2, 2024 · 3 comments

Comments

@BulatSaif
Copy link

BulatSaif commented Feb 2, 2024 •
edited
Loading

Current behavior:
Binary do not contain information about git commit:

docker run mythicalgamesengineering/parity:v1.13.3 /usr/bin/mythos-node --version
mythos-node 1.13.0-unknown <- also not version is incorrect should be 1.13.3

Expected behavior:

docker run mythicalgamesengineering/parity:v1.13.3 /usr/bin/mythos-node --version
mythical-node 1.13.3-680adc78ab3
@BulatSaif BulatSaif transferred this issue from another repository Jul 25, 2024
@BulatSaif BulatSaif changed the title missing git commit in version Missing git commit in version Jul 25, 2024
@gautamdhameja
Copy link
Collaborator

We will fix this in the next node release upgrade.

@BulatSaif
Copy link
Author

any updates on this?

@BulatSaif
Copy link
Author

The latest release still has the unknown string instead of the Git commit.

docker run mythicalgamesengineering/parity:v1.17.1 /usr/bin/mythos-node --version
mythos-node 1.17.1-unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gautamdhameja @BulatSaif