refactor: Remove Carthage dependency (#1763)

Author: dplewis

.github/workflows/ci.yml

@@ -61,18 +61,6 @@ jobs:
       - name: Bundle Install
         if: steps.cache-gems.outputs.cache-hit != 'true'
         run: bundle install
-      - name: Cache Carthage
-        uses: actions/cache@v3
-        id: carthage-cache
-        with:
-          path: Carthage
-          key: ${{ runner.os }}-carthage-${{ hashFiles('**/Cartfile.resolved') }}
-          restore-keys: |
-            ${{ runner.os }}-carthage-
-      - name: Carthage
-        if: ${{ steps.carthage-cache.outputs.cache-hit != 'true' }}
-        run: |
-          carthage bootstrap --use-xcframeworks
       - name: Build-Test
         run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake ${{ matrix.script == 'xcode15' && 'build:starters' || matrix.script }}
         env:

.gitmodules

@@ -1,9 +1,3 @@
 [submodule "Vendor/xctoolchain"]
 	path = Vendor/xctoolchain
 	url = https://github.com/parse-community/xctoolchain.git
-[submodule "Carthage/Checkouts/Bolts-ObjC"]
-	path = Carthage/Checkouts/Bolts-ObjC
-	url = https://github.com/BoltsFramework/Bolts-ObjC.git
-[submodule "Carthage/Checkouts/facebook-ios-sdk"]
-	path = Carthage/Checkouts/facebook-ios-sdk
-	url = https://github.com/facebook/facebook-ios-sdk.git

Cartfile

@@ -9,11 +9,7 @@
 
 #import <Foundation/Foundation.h>
 
-#if __has_include(<Bolts/BFTask.h>)
-#import <Bolts/BFTask.h>
-#else
-#import "BFTask.h"
-#endif
+@import Bolts;
 
 #import "PFConstants.h"
 

Cartfile.resolved

@@ -9,7 +9,7 @@
 
 #import "OCMock+Parse.h"
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFCommandRunning.h"

Carthage/Checkouts/Bolts-ObjC

@@ -9,7 +9,7 @@
 
 import Foundation
 
-import Parse
+import ParseCore
 
 @objc
 public class SwiftSubclass: PFObject, PFSubclassing {

Carthage/Checkouts/facebook-ios-sdk

@@ -9,7 +9,7 @@
 
 #import "PFTestCase.h"
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFTestSwizzlingUtilities.h"
 

Parse/Parse.xcodeproj/project.pbxproj

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFAnalyticsController.h"
 #import "PFUnitTestCase.h"

Parse/Parse/Source/PFAnalytics.h

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFAnonymousAuthenticationProvider.h"
 #import "PFTestCase.h"

Parse/Tests/Other/OCMock/OCMock+Parse.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "OCMock+Parse.h"
 #import "PFCloudCodeController.h"

Parse/Tests/Other/Swift/SwiftSubclass.swift

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "OCMock+Parse.h"
 #import "PFCommandResult.h"

Parse/Tests/Other/TestCases/TestCase/PFTestCase.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFConfigController.h"
 #import "PFConfig_Private.h"

Parse/Tests/Unit/AnalyticsUnitTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "BFTask+Private.h"
 #import "PFCommandResult.h"

Parse/Tests/Unit/AnonymousAuthenticationProviderTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFACLPrivate.h"
 #import "PFCoreManager.h"

Parse/Tests/Unit/CloudCodeControllerTests.m

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFExtensionDataSharingTestHelper.h"
 #import "PFFileManager.h"

Parse/Tests/Unit/ConfigControllerTests.m

@@ -9,9 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
-@import Bolts.BFTask;
-@import Bolts.BFTaskCompletionSource;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFCommandRunning.h"

Parse/Tests/Unit/ConfigUnitTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCoreManager.h"
 #import "PFFileController.h"

Parse/Tests/Unit/CurrentConfigControllerTests.m

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "BFTask+Private.h"
 #import "PFObject.h"

Parse/Tests/Unit/DefaultACLControllerTests.m

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFObject.h"
 #import "PFOfflineStore.h"

Parse/Tests/Unit/ExtensionDataSharingTests.m

@@ -9,8 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "OCMock+Parse.h"
 #import "PFCommandResult.h"

Parse/Tests/Unit/FileControllerTests.m

@@ -11,8 +11,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFExecutor;
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFCommandRunning.h"

Parse/Tests/Unit/FileUnitTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandRunning.h"
 #import "PFFileManager.h"

Parse/Tests/Unit/ObjectFilePersistenceControllerTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCurrentInstallationController.h"
 #import "PFInstallation.h"

Parse/Tests/Unit/ObjectOfflineTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFCommandRunning.h"

Parse/Tests/Unit/OfflineQueryControllerTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.H>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCoreManager.h"
 #import "PFCurrentInstallationController.h"

Parse/Tests/Unit/PurchaseControllerTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCachedQueryController.h"
 #import "PFCommandResult.h"

Parse/Tests/Unit/PurchaseUnitTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
+@import Bolts;
 
 #import "BFTask+Private.h"
 #import "PFCommandResult.h"

Parse/Tests/Unit/PushChannelsControllerTests.m

@@ -9,7 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCoreManager.h"
 #import "PFMacros.h"

Parse/Tests/Unit/PushControllerTests.m

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFMockURLProtocol.h"
 #import "PFRelation.h"

Parse/Tests/Unit/PushUnitTests.m

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "BFTask+Private.h"
 #import "PFFileManager.h"

Parse/Tests/Unit/QueryCachedControllerTests.m

@@ -9,8 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFCommandRunningConstants.h"

Parse/Tests/Unit/QueryControllerUnitTests.m

@@ -9,8 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFConstants.h"

Parse/Tests/Unit/QueryUnitTests.m

@@ -9,8 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFMacros.h"

Parse/Tests/Unit/RoleUnitTests.m

@@ -9,8 +9,7 @@
 
 #import <OCMock/OCMock.h>
 
-@import Bolts.BFCancellationTokenSource;
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "PFCommandResult.h"
 #import "PFTestCase.h"

Parse/Tests/Unit/SQLiteDatabaseTest.m

@@ -7,7 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
-@import Bolts.BFTask;
+@import Bolts;
 
 #import "OCMock+Parse.h"
 #import "PFCommandResult.h"