puppet-lint: autofix

Author: bastelfreak

examples/replicaset.pp

@@ -7,8 +7,8 @@
     bind_ip    => ['0.0.0.0'],
     replset    => 'rsmain',
   }
-  mongodb_replset{'rsmain':
-    members => ['mongo1:27017', 'mongo2:27017', 'mongo3:27017' ],
+  mongodb_replset { 'rsmain':
+    members => ['mongo1:27017', 'mongo2:27017', 'mongo3:27017'],
     arbiter => 'mongo3:27017',
   }
 }

examples/sharding.pp

@@ -1,56 +1,51 @@
 node 'mongos' {
-
-  class {'mongodb::globals':
+  class { 'mongodb::globals':
     manage_package_repo => true,
   }
-  -> class {'mongodb::server':
+  -> class { 'mongodb::server':
     configsvr => true,
     bind_ip   => [$facts['networking']['ip']],
   }
-  -> class {'mongodb::client': }
-  -> class {'mongodb::mongos':
+  -> class { 'mongodb::client': }
+  -> class { 'mongodb::mongos':
     configdb => ["${facts['networking']['ip']}:27019"],
   }
   -> mongodb_shard { 'rs1' :
     member => 'rs1/mongod1:27018',
     keys   => [{
-      'rs1.foo' => {
-        'name' => 1,
-      }
+        'rs1.foo' => {
+          'name' => 1,
+        }
     }],
   }
-
 }
 
 node 'mongod1' {
-
-  class {'mongodb::globals':
+  class { 'mongodb::globals':
     manage_package_repo => true,
   }
-  -> class {'mongodb::server':
+  -> class { 'mongodb::server':
     shardsvr => true,
     replset  => 'rs1',
     bind_ip  => [$facts['networking']['ip']],
   }
-  -> class {'mongodb::client': }
-  mongodb_replset{'rs1':
+  -> class { 'mongodb::client': }
+  mongodb_replset { 'rs1':
     members => ['mongod1:27018', 'mongod2:27018'],
   }
 }
 
 node 'mongod2' {
-
-  class {'mongodb::globals':
+  class { 'mongodb::globals':
     manage_package_repo => true,
   }
-  -> class {'mongodb::server':
+  -> class { 'mongodb::server':
     shardsvr => true,
     replset  => 'rs1',
     bind_ip  => [$facts['networking']['ip']],
   }
-  -> class {'mongodb::client': }
-  mongodb_replset{'rs1':
+  -> class { 'mongodb::client': }
+  mongodb_replset { 'rs1':
     members => ['mongod1:27018', 'mongod2:27018'],
   }
-
 }

manifests/db.pp

@@ -19,7 +19,6 @@
   Array[String]    $roles         = ['dbAdmin'],
   Integer[0]       $tries         = 10,
 ) {
-
   unless $facts['mongodb_is_master'] == 'false' { # lint:ignore:quoted_booleans
     mongodb_database { $db_name:
       ensure => present,

manifests/globals.pp

@@ -31,7 +31,6 @@
   $pidfilemode           = undef,
   $manage_pidfile        = undef,
 ) {
-
   if $use_enterprise_repo {
     $edition = 'enterprise'
   } else {

manifests/mongos.pp

@@ -38,5 +38,4 @@
   } else {
     Class['mongodb::mongos::service'] -> Class['mongodb::mongos::config'] -> Class['mongodb::mongos::install']
   }
-
 }

manifests/mongos/install.pp

@@ -3,13 +3,11 @@
   $package_ensure = $mongodb::mongos::package_ensure,
   $package_name   = $mongodb::mongos::package_name,
 ) {
-
   unless defined(Package[$package_name]) {
     package { 'mongodb_mongos':
       ensure => $package_ensure,
       name   => $package_name,
       tag    => 'mongodb_package',
     }
   }
-
 }

manifests/mongos/service.pp

@@ -10,7 +10,6 @@
   $bind_ip          = $mongodb::mongos::bind_ip,
   $port             = $mongodb::mongos::port,
 ) {
-
   if $package_ensure in ['absent', 'purged'] {
     $real_service_ensure = 'stopped'
     $real_service_enable = false
@@ -43,5 +42,4 @@
       }
     }
   }
-
 }

manifests/opsmanager.pp

@@ -55,7 +55,6 @@
   Optional[Integer] $snapshot_monthly_retention  = undef, # Default: 1
   Optional[Integer] $versions_directory          = undef, # Linux default: /opt/mongodb/mms/mongodb-releases/
 ) {
-
   case $package_ensure {
     'absent': {
       $my_package_ensure = 'absent'

manifests/replset.pp

@@ -1,8 +1,7 @@
 # Wrapper class useful for hiera based deployments
-class mongodb::replset(
+class mongodb::replset (
   $sets = undef
 ) {
-
   if $sets {
     create_resources(mongodb_replset, $sets)
   }

manifests/server.pp

@@ -80,7 +80,6 @@
   Boolean $store_creds                                  = $mongodb::params::store_creds,
   Array $admin_roles                                    = $mongodb::params::admin_roles,
 ) inherits mongodb::params {
-
   contain mongodb::server::install
   contain mongodb::server::config
   contain mongodb::server::service
@@ -122,7 +121,6 @@
       if $replset_config {
         # Copy it to REAL value
         $_replset_config = $replset_config
-
       } else {
         # Build up a config hash
         $_replset_config = {
@@ -144,7 +142,6 @@
       if $create_admin {
         Class['mongodb::replset'] -> Mongodb::Db['admin']
       }
-
     }
   }
 }

manifests/server/config.pp

@@ -73,10 +73,9 @@
     group => $group,
   }
 
-  if ($logpath and $syslog) { fail('You cannot use syslog with logpath')}
+  if ($logpath and $syslog) { fail('You cannot use syslog with logpath') }
 
   if ($ensure == 'present' or $ensure == true) {
-
     # Exists for future compatibility and clarity.
     if $auth {
       $noauth = false
@@ -99,7 +98,6 @@
       $storage_engine_internal = $storage_engine
     }
 
-
     # Pick which config content to use
     if $config_content {
       $cfg_content = $config_content
@@ -165,7 +163,7 @@
   if $handle_creds {
     if $auth and $store_creds {
       file { $rcfile:
-        ensure  => present,
+        ensure  => file,
         content => template('mongodb/mongorc.js.erb'),
         owner   => 'root',
         group   => 'root',

manifests/server/service.pp

@@ -55,5 +55,4 @@
       }
     }
   }
-
 }

manifests/shardsvr.pp

@@ -1,10 +1,8 @@
 # Wrapper class useful for hiera based deployments
-class mongodb::shardsvr(
+class mongodb::shardsvr (
   $shards = undef
 ) {
-
   if $shards {
     create_resources(mongodb_shard, $shards)
   }
-
 }

spec/classes/server_spec.rb

@@ -237,7 +237,7 @@
 
           it {
             is_expected.to contain_file('/root/.mongorc.js').
-              with_ensure('present').
+              with_ensure('file').
               with_owner('root').
               with_group('root').
               with_mode('0600').