fix: the server could crash if a client sends invalid frames

jonasgloning · jonasgloning · commit 33e6d755cc85 · 2022-11-10T11:33:37.000+01:00
Closes #290
diff --git a/src/services/webSocketServer/index.ts b/src/services/webSocketServer/index.ts
@@ -47,6 +47,7 @@ export class WebSocketServer extends EventEmitter implements IWebSocketServer {
   }
 
   private _onSocketConnection(socket: MyWebSocket, req: IncomingMessage): void {
+    socket.on("error", this._onSocketError);
     const { query = {} } = url.parse(req.url ?? '', true);
 
     const { id, token, key }: IAuthParams = query;

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ export class WebSocketServer extends EventEmitter implements IWebSocketServer {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`private _onSocketConnection(socket: MyWebSocket, req: IncomingMessage): void {`
	`50`	`+ socket.on("error", this._onSocketError);`
`50`	`51`	`const { query = {} } = url.parse(req.url ?? '', true);`
`51`	`52`
`52`	`53`	`const { id, token, key }: IAuthParams = query;`