fixup! ci(aio): change AIO preview server stuff to use CircleCI

Author: petebacondarwin

Diff for: aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/build-retriever.ts

@@ -42,7 +42,7 @@ export class BuildRetriever {
   public async downloadBuildArtifact(buildNum: number, pr: number, sha: string, artifactPath: string) {
     try {
       const outPath = computeArtifactDownloadPath(this.downloadDir, pr, sha, artifactPath);
-      const downloadExists = await promisify(fs.exists)(outPath);
+      const downloadExists = await new Promise(resolve => fs.exists(outPath, exists => resolve(exists)));
       if (!downloadExists) {
         const url = await this.api.getBuildArtifactUrl(buildNum, artifactPath);
         const response = await fetch(url, {size: this.downloadSizeLimit});

Diff for: aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/build-retriever.spec.ts

@@ -41,7 +41,7 @@ describe('BuildRetriever', () => {
 
     EXISTS_RESULT = false;
     existsSpy = spyOn(fs, 'exists').and.callFake(
-      (_path: string, callback: (err?: any) => {}) => callback(EXISTS_RESULT),
+      (_path: string, callback: (exists: boolean) => {}) => callback(EXISTS_RESULT),
     );
   });
 
@@ -96,6 +96,17 @@ describe('BuildRetriever', () => {
       artifactRequest.done();
     });
 
+    it('should not download the artifact if it already exists', async () => {
+      const artifactRequestInterceptor = nock(BASE_URL).get(ARTIFACT_PATH);
+      const artifactRequest = artifactRequestInterceptor.reply(200, ARTIFACT_CONTENTS);
+      EXISTS_RESULT = true;
+      await retriever.downloadBuildArtifact(12345, 777, 'COMMIT', ARTIFACT_PATH);
+      expect(existsSpy).toHaveBeenCalled();
+      expect(getBuildArtifactUrlSpy).not.toHaveBeenCalled();
+      expect(artifactRequest.isDone()).toEqual(false);
+      nock.removeInterceptor(artifactRequestInterceptor);
+    });
+
     it('should write the artifact file to disk', async () => {
       const artifactRequest = nock(BASE_URL).get(ARTIFACT_PATH).reply(200, ARTIFACT_CONTENTS);
       await retriever.downloadBuildArtifact(12345, 777, 'COMMIT', ARTIFACT_PATH);