Upgrade to pions/sdp v2

maxhawkins · Sean-Der · commit 9cba54cfd06a · 2019-02-18T11:47:05.000-08:00
Relates to #417
diff --git a/go.mod b/go.mod
@@ -6,7 +6,7 @@ require (
 	github.com/pions/rtcp v1.0.0
 	github.com/pions/rtp v1.0.0
 	github.com/pions/sctp v1.3.1
-	github.com/pions/sdp v1.3.0
+	github.com/pions/sdp/v2 v2.0.0
 	github.com/pions/srtp v1.0.3
 	github.com/pions/stun v0.2.0
 	github.com/pions/transport v0.1.0
diff --git a/go.sum b/go.sum
@@ -32,8 +32,8 @@ github.com/pions/rtp v1.0.0/go.mod h1:GDIt4UYlSz7za4vfaLqihGJJ+yLvgPshnqrF/lm3vc
 github.com/pions/sctp v1.3.0/go.mod h1:GZTG/xApE7wdUFEQq2Rmzgxl/+YaB/L1k8xUl1D5bmo=
 github.com/pions/sctp v1.3.1 h1:V5cRHMt+G9ufc44ITZvcEj7/nUyDukkB3Qr08TT29k4=
 github.com/pions/sctp v1.3.1/go.mod h1:GZTG/xApE7wdUFEQq2Rmzgxl/+YaB/L1k8xUl1D5bmo=
-github.com/pions/sdp v1.3.0 h1:HIv6ZvdzRPq+H4T8EV8K9pZ4EGnYOr14HFZ9Rksh6/0=
-github.com/pions/sdp v1.3.0/go.mod h1:moNMmnVSlx8rBBb39U9t0Rdr7xvMlqiJjHlMESRad5k=
+github.com/pions/sdp/v2 v2.0.0 h1:tWh8ehKPtXTaFYF12sBAHqYmhV36Q7YTmm3O6ycNa6M=
+github.com/pions/sdp/v2 v2.0.0/go.mod h1:KGRBcHfpkgJXjrzKJz2wj/Jf1KWnsHdoIiqtayQ5QmE=
 github.com/pions/srtp v1.0.3 h1:0rlg7yUHQblFA1e451mhx50IkA7+e48ja5K8mljyMYY=
 github.com/pions/srtp v1.0.3/go.mod h1:egXe0STDyQDXLm7hjOMzuk7rkAhJ1SHOx+tTgtw/cQs=
 github.com/pions/stun v0.2.0 h1:spIzpfkEg6HV+2iIo6qeOsAjtadZKzbXbrd2e9ZCCcs=
diff --git a/icecandidate.go b/icecandidate.go
@@ -5,7 +5,7 @@ import (
 	"fmt"
 	"net"
 
-	"github.com/pions/sdp"
+	"github.com/pions/sdp/v2"
 	"github.com/pions/webrtc/pkg/ice"
 )
 
diff --git a/icecandidate_test.go b/icecandidate_test.go
@@ -4,7 +4,7 @@ import (
 	"net"
 	"testing"
 
-	"github.com/pions/sdp"
+	"github.com/pions/sdp/v2"
 	"github.com/pions/webrtc/pkg/ice"
 	"github.com/stretchr/testify/assert"
 )
diff --git a/mediaengine.go b/mediaengine.go
@@ -5,7 +5,7 @@ import (
 
 	"github.com/pions/rtp"
 	"github.com/pions/rtp/codecs"
-	"github.com/pions/sdp"
+	"github.com/pions/sdp/v2"
 )
 
 // PayloadTypes for the default codecs
diff --git a/mediaengine_test.go b/mediaengine_test.go
@@ -3,7 +3,7 @@ package webrtc
 import (
 	"testing"
 
-	"github.com/pions/sdp"
+	"github.com/pions/sdp/v2"
 	"github.com/stretchr/testify/assert"
 )
 
diff --git a/peerconnection.go b/peerconnection.go
@@ -14,7 +14,7 @@ import (
 
 	"github.com/pions/rtcp"
 	"github.com/pions/rtp"
-	"github.com/pions/sdp"
+	"github.com/pions/sdp/v2"
 	"github.com/pions/webrtc/pkg/ice"
 	"github.com/pions/webrtc/pkg/logging"
 	"github.com/pions/webrtc/pkg/rtcerr"
@@ -1428,8 +1428,8 @@ func (pc *PeerConnection) addRTPMediaSection(d *sdp.SessionDescription, codecTyp
 		WithValueAttribute(sdp.AttrKeyConnectionSetup, dtlsRole.String()). // TODO: Support other connection types
 		WithValueAttribute(sdp.AttrKeyMID, midValue).
 		WithICECredentials(iceParams.UsernameFragment, iceParams.Password).
-		WithPropertyAttribute(sdp.AttrKeyRtcpMux).  // TODO: support RTCP fallback
-		WithPropertyAttribute(sdp.AttrKeyRtcpRsize) // TODO: Support Reduced-Size RTCP?
+		WithPropertyAttribute(sdp.AttrKeyRTCPMux).  // TODO: support RTCP fallback
+		WithPropertyAttribute(sdp.AttrKeyRTCPRsize) // TODO: Support Reduced-Size RTCP?
 
 	for _, codec := range pc.api.mediaEngine.getCodecsByKind(codecType) {
 		media.WithCodec(codec.PayloadType, codec.Name, codec.ClockRate, codec.Channels, codec.SDPFmtpLine)
diff --git a/sessiondescription.go b/sessiondescription.go
@@ -1,7 +1,7 @@
 package webrtc
 
 import (
-	"github.com/pions/sdp"
+	"github.com/pions/sdp/v2"
 )
 
 // SessionDescription is used to expose local and remote session descriptions.

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import (`
`5`	`5`	`"fmt"`
`6`	`6`	`"net"`
`7`	`7`
`8`		`- "github.com/pions/sdp"`
	`8`	`+ "github.com/pions/sdp/v2"`
`9`	`9`	`"github.com/pions/webrtc/pkg/ice"`
`10`	`10`	`)`
`11`	`11`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import (`
`4`	`4`	`"net"`
`5`	`5`	`"testing"`
`6`	`6`
`7`		`- "github.com/pions/sdp"`
	`7`	`+ "github.com/pions/sdp/v2"`
`8`	`8`	`"github.com/pions/webrtc/pkg/ice"`
`9`	`9`	`"github.com/stretchr/testify/assert"`
`10`	`10`	`)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import (`
`5`	`5`
`6`	`6`	`"github.com/pions/rtp"`
`7`	`7`	`"github.com/pions/rtp/codecs"`
`8`		`- "github.com/pions/sdp"`
	`8`	`+ "github.com/pions/sdp/v2"`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`// PayloadTypes for the default codecs`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ package webrtc`
`3`	`3`	`import (`
`4`	`4`	`"testing"`
`5`	`5`
`6`		`- "github.com/pions/sdp"`
	`6`	`+ "github.com/pions/sdp/v2"`
`7`	`7`	`"github.com/stretchr/testify/assert"`
`8`	`8`	`)`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`package webrtc`
`2`	`2`
`3`	`3`	`import (`
`4`		`- "github.com/pions/sdp"`
	`4`	`+ "github.com/pions/sdp/v2"`
`5`	`5`	`)`
`6`	`6`
`7`	`7`	`// SessionDescription is used to expose local and remote session descriptions.`