Skip to content

Add test for shapefile input #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pjsier opened this issue Sep 28, 2021 · 2 comments · Fixed by #21
Closed

Add test for shapefile input #20

pjsier opened this issue Sep 28, 2021 · 2 comments · Fixed by #21
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@pjsier
Copy link
Owner

pjsier commented Sep 28, 2021

Currently there are test for every input format except for shapefiles, partially because it involves multiple files.

We can create a test here by converting one of the files in the fixtures directory into shapefile format and using that to create a test similar to the GeoJSON test. Converting the GeoJSON file would probably be easiest. The conversion will result in multiple files that should all be included in the fixtures directory

mapshaper is one tool that might be helpful in converting GeoJSON to shapefiles

@pjsier pjsier added good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Sep 28, 2021
@niwa-s
Copy link
Contributor

niwa-s commented Oct 8, 2021

May I work on it?

@pjsier
Copy link
Owner Author

pjsier commented Oct 8, 2021

@niwa-s sure! Assigning you now. Feel free to post any questions here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants