Skip to content

Commit cf5f132

Browse files
Xharktensorflower-gardener
authored andcommitted
Internal change
PiperOrigin-RevId: 300447325
1 parent b39958c commit cf5f132

File tree

6 files changed

+1
-36
lines changed

6 files changed

+1
-36
lines changed

official/benchmark/keras_imagenet_benchmark.py

-2
Original file line numberDiff line numberDiff line change
@@ -1305,7 +1305,6 @@ def __init__(self, root_data_dir=None, **kwargs):
13051305
'model': 'resnet50_v1.5',
13061306
'optimizer': 'mobilenet_default',
13071307
'initial_learning_rate_per_sample': 0.0000039,
1308-
'use_tf_keras_layers': True,
13091308
'pretrained_filepath': tf.train.latest_checkpoint(
13101309
os.path.join(root_data_dir, 'resnet50')),
13111310
'pruning_begin_step': 0,
@@ -1369,7 +1368,6 @@ def __init__(self, **kwargs):
13691368
default_flags = {
13701369
'model': 'resnet50_v1.5',
13711370
'optimizer': 'mobilenet_default',
1372-
'use_tf_keras_layers': True,
13731371
}
13741372
super(Resnet50KerasPruningBenchmarkReal, self).__init__(
13751373
default_flags=default_flags, **kwargs)

official/vision/image_classification/common.py

-6
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,6 @@ def define_keras_flags(
275275
help='Whether to build a tf.while_loop inside the training loop on the '
276276
'host. Setting it to True is critical to have peak performance on '
277277
'TPU.')
278-
flags.DEFINE_boolean(
279-
name='use_tf_keras_layers', default=False,
280-
help='Whether to use tf.keras.layers instead of tf.python.keras.layers.'
281-
'It only changes imagenet resnet model layers for now. This flag is '
282-
'a temporal flag during transition to tf.keras.layers. Do not use this '
283-
'flag for external usage. this will be removed shortly.')
284278

285279
if model:
286280
flags.DEFINE_string('model', 'resnet50_v1.5',

official/vision/image_classification/resnet/resnet_model.py

+1-25
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131

3232
from tensorflow.python.keras import backend
3333
from tensorflow.python.keras import initializers
34-
from tensorflow.python.keras import layers as tf_python_keras_layers
3534
from tensorflow.python.keras import models
3635
from tensorflow.python.keras import regularizers
3736
from official.vision.image_classification import imagenet_preprocessing
@@ -40,30 +39,7 @@
4039
BATCH_NORM_DECAY = 0.9
4140
BATCH_NORM_EPSILON = 1e-5
4241

43-
layers = tf_python_keras_layers
44-
45-
46-
def change_keras_layer(use_tf_keras_layers=False):
47-
"""Change layers to either tf.keras.layers or tf.python.keras.layers.
48-
49-
Layer version of tf.keras.layers is depends on tensorflow version, but
50-
tf.python.keras.layers checks environment variable TF2_BEHAVIOR.
51-
This function is a temporal function to use tf.keras.layers.
52-
Currently, tf v2 batchnorm layer is slower than tf v1 batchnorm layer.
53-
this function is useful for tracking benchmark result for each version.
54-
This function will be removed when we use tf.keras.layers as default.
55-
56-
TODO(b/146939027): Remove this function when tf v2 batchnorm reaches training
57-
speed parity with tf v1 batchnorm.
58-
59-
Args:
60-
use_tf_keras_layers: whether to use tf.keras.layers.
61-
"""
62-
global layers
63-
if use_tf_keras_layers:
64-
layers = tf.keras.layers
65-
else:
66-
layers = tf_python_keras_layers
42+
layers = tf.keras.layers
6743

6844

6945
def _gen_l2_regularizer(use_l2_regularizer=True):

official/vision/image_classification/resnet_imagenet_main.py

-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ def run(flags_obj):
183183
model = trivial_model.trivial_model(
184184
imagenet_preprocessing.NUM_CLASSES)
185185
elif flags_obj.model == 'resnet50_v1.5':
186-
resnet_model.change_keras_layer(flags_obj.use_tf_keras_layers)
187186
model = resnet_model.resnet50(
188187
num_classes=imagenet_preprocessing.NUM_CLASSES)
189188
elif flags_obj.model == 'mobilenet':

official/vision/image_classification/resnet_imagenet_test.py

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ class KerasImagenetTest(tf.test.TestCase):
5050
"-model", "resnet50_v1.5",
5151
"-optimizer", "resnet50_default",
5252
"-pruning_method", "polynomial_decay",
53-
"-use_tf_keras_layers", "true",
5453
],
5554
"mobilenet": [
5655
"-model", "mobilenet",

official/vision/image_classification/resnet_runnable.py

-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ def __init__(self, flags_obj, time_callback, epoch_steps):
7070
else:
7171
self.input_fn = imagenet_preprocessing.input_fn
7272

73-
resnet_model.change_keras_layer(flags_obj.use_tf_keras_layers)
7473
self.model = resnet_model.resnet50(
7574
num_classes=imagenet_preprocessing.NUM_CLASSES,
7675
batch_size=flags_obj.batch_size,

0 commit comments

Comments
 (0)