Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to re2 #256

Open
PhilippMDoerner opened this issue Feb 16, 2025 · 0 comments
Open

Migrate to re2 #256

PhilippMDoerner opened this issue Feb 16, 2025 · 0 comments

Comments

@PhilippMDoerner
Copy link
Contributor

PhilippMDoerner commented Feb 16, 2025

The regex lib appears to have deprecated its re/RegexMatch/Regex API in favour of something more macro based (?).
The API is identical, but the types and symbol-names are different.

You notice this if you use regex-routes in prologue, as you now get these warnings:
Warning: use re2(static string) instead; re is deprecated [Deprecated]

Now they're re2/RegexMatch2/Regex2. I did 5 minutes of playing around and it seems this will require adjusting a few things. The few I could think of:

  • Adjust exports of core/basicregex.nim
  • Adjust addRoute proc in core/applications.nim
  • Adjust initRePath proc in core/route.nim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant