Skip to content

[Contracts] prevent combat sessions sticking around in the graph #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisfarms opened this issue May 1, 2024 · 0 comments · Fixed by #1380
Closed

[Contracts] prevent combat sessions sticking around in the graph #1364

chrisfarms opened this issue May 1, 2024 · 0 comments · Fixed by #1380
Assignees
Labels
feature Something we should add or improve

Comments

@chrisfarms
Copy link
Contributor

old combat sessions always hang around in the zone query.

after 5 hours of (wrongly) investigating issues with combat I had enough combat session to start noticing the affects of all the old sessions in the data (large query size, long loops)

we should probably change the edges so that finalizing actually disconnects the item from the zone query, either by mounting it on tiles or something else.

this would be a contract change, so not ideal.

I believe we needed them to stick around because of session bags ... however we now how the player wallet, so could send rewards directly there and drop the need for reward bags entirely (which would also be a perf/query win)

@ldunnplaymint ldunnplaymint changed the title prevent combat sessions sticking around in the graph [Contracts] prevent combat sessions sticking around in the graph May 2, 2024
@ldunnplaymint ldunnplaymint added the feature Something we should add or improve label May 3, 2024
@chrisfarms chrisfarms mentioned this issue May 7, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something we should add or improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants