Skip to content

Image related blocks #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrTango opened this issue Apr 10, 2025 · 3 comments
Open

Image related blocks #6969

MrTango opened this issue Apr 10, 2025 · 3 comments
Labels
01 type: bug 30 needs: triage New issue that needs confirmation before work begins

Comments

@MrTango
Copy link
Contributor

MrTango commented Apr 10, 2025

Currently Images in Volto are also defining the original image in srcset definitions, which the browser will load when existing scales seem to small. But this is wrong.

Imagine a user uploads an image directly coming from a digital camera.
This image will be bigger than 10MB. With this setting in place, the browser will often take this image.

The original image should never be loaded in templates.
If we need bigger scales, then they have to be created and used.
The original image is uncompressed and unscaled.
Which is useful for some rare cases.
But for templates we should define scales which are big enough. In Volto Light Theme for example with the Image block, we need around 2500px in width, to fill the whole screen, but never 6000px or more as we have in camera images.

The problem was introduced here:
https://github.com/plone/volto/pull/6634/files

@MrTango MrTango added 01 type: bug 30 needs: triage New issue that needs confirmation before work begins labels Apr 10, 2025
Copy link

boring-cyborg bot commented Apr 10, 2025

Thanks for opening your first issue here! Your engagement is essential for open source projects, including Plone. 🤗

If you haven't done so already, read Plone's Code of Conduct. Also please follow the issue template, as it helps both you and other community members contribute more effectively.

If your issue is a feature request, others may raise its prominence through feature voting.

Welcome to the Plone community! 🎉

@davisagli
Copy link
Member

I disagree it's wrong to include the original image, but I agree it would make sense to include a larger scale in the default plone.volto image scales (https://github.com/plone/plone.volto/blob/main/src/plone/volto/profiles/default/registry/plone.base.interfaces.controlpanel.IImagingSchema.xml)

@MrTango
Copy link
Contributor Author

MrTango commented Apr 19, 2025

if this is fixed, the issue is mostly about providing the right scales.
#6687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug 30 needs: triage New issue that needs confirmation before work begins
Projects
None yet
Development

No branches or pull requests

2 participants