Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

silhouette_analysis plot improvements #150

Closed
edublancas opened this issue Dec 28, 2022 · 1 comment · Fixed by #213
Closed

silhouette_analysis plot improvements #150

edublancas opened this issue Dec 28, 2022 · 1 comment · Fixed by #213
Assignees

Comments

@edublancas
Copy link
Contributor

here are some things we can improve in the silhouette_analysis

  • silhouette_analysis_from_results should not be part of the public API since it's method that it's used as an intermediate step, so we should rename it to something like _silhouette_analysis. I think this computes silhouettes for a single cluster so maybe _silhouette_analysis_one_cluster

  • silhouette_analysis had a hardcoded figure size (which I already removed); however, to make the tests pass, I had to move this hardcoded figure size to the tests, we should remove this

@neelasha23
Copy link
Contributor

silhouette_analysis_from_results was added to be consistent with elbow_curve_from_results (user wants to generate plots from custom model). Do we need to make elbow_curve_from_results internal too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants