removed n_clusters from elbow_curve

[WSShawn]

Describe your changes

removed n_clusters from elbow_curve()

Issue ticket number and link

Closes #190

Checklist before requesting a review

• I have performed a self-review of my code
• I have added thorough tests (when necessary).
• I have added the right documentation in the docstring and changelog (when needed)

---

📚 Documentation preview 📚: https://sklearn-evaluation--247.org.readthedocs.build/en/247/

[WSShawn]

still working on fixing the test_clustering.oy file

[edublancas]

as a general tip: open the PR until it's ready. if you want to open a PR for early feedback or to test the CI, mark is as a draft

[coveralls]

Pull Request Test Coverage Report for Build 4015018253

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.1%) to 94.297%

---

Files with Coverage Reduction	New Missed Lines	%
src/sklearn_evaluation/telemetry.py	2	96.92%

Totals
Change from base Build 4010433489:	0.1%
Covered Lines:	2745
Relevant Lines:	2911

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 4017940789

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.05%) to 94.223%

---

Files with Coverage Reduction	New Missed Lines	%
src/sklearn_evaluation/plot/clustering.py	2	98.36%

Totals
Change from base Build 4010433489:	0.05%
Covered Lines:	2675
Relevant Lines:	2839

---

💛 - Coveralls

[idomic]

@WSShawn the CI is failing, converting to draft

[WSShawn]

Sorry for all the commits, I'll mark it as draft first next time. Also, do we have any experience dealing with the Tcl installation error before? I'm not sure what that means. @edublancas @idomic

[edublancas]

tcl is a conda error, trigger the CI again to fix it

[WSShawn]

@edublancas need some help with the readthedocs error.

[edublancas]

the error is: _queue.Empty. I've seen this before, it's an intermittent error in the jupyter-client, nothing we can do but to rebuild the docs. i re-triggered the build https://readthedocs.org/projects/sklearn-evaluation/builds/19287048/

[WSShawn]

Thanks! Let's see how it goes this time.

[WSShawn]

I think it's the same error again

[edublancas]

ok, looked at the error. I think the real reason is the timeout - there is one cell in a notebook that's taking longer than expected. check out the jupyter-book documentation, I remember seeing how to extend the cell timeout; if that doesn't work, then we'd need to investigate why this is failing. perhaps we can reduce the runtime of that cell to fix it

[WSShawn]

@edublancas found this about cell execution timeout. Is this what we want? If yes, which file did we use to set up sphinx? Thanks!

[gtduncan]

Having the same issue, seems to be set in docs/conf.py? (looking at execution_timeout = 30)

[WSShawn]

Thanks! Any specific value did you use to fix this? @gtduncan

[gtduncan]

It seems to fail even when I set it fairly high (120 seconds), maybe it's something wrong with the cell

[WSShawn]

@edublancas could this cell be trying to extract n_clusters?

Here is a preview of the cell contents:

['# models with their corresponding parameters', 'params = [{', " 'model': 'sklearn.ensemble.RandomForestRegressor',", " 'params': {", " 'n_estimators': 50"]
...
["files = [f'{i}.ipynb' for i in ids]", '', '# execute notebooks using papermill', 'for f, p in zip(files, params):', " pm.execute_notebook('train.ipynb', output_path=f, parameters=p)"]

[idomic]

@WSShawn please rebase on master and let me know if this is ready for review.

[edublancas]

remember to also delete the deprecation message in the docstring, the one that begins with .. deprecated:: 0.9

[WSShawn]

ok, I'll delete it tonight after my class