Skip to content

Implement LensFlareEffect #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
Tracked by #600
vanruesc opened this issue Feb 15, 2024 · 7 comments
Open
3 tasks
Tracked by #600

Implement LensFlareEffect #581

vanruesc opened this issue Feb 15, 2024 · 7 comments
Assignees
Milestone

Comments

@vanruesc
Copy link
Member

vanruesc commented Feb 15, 2024

Description

Implement a LensFlareEffect.

References:

Tasks

  • Create LensFlareEffect.
  • Create lens-flare demo.
  • Add unit test.

Implementation Details

See #616 regarding flare/glare.

@kitaedesigns
Copy link

kitaedesigns commented Oct 8, 2024

Leaving this here as a reference for a nice and customizable LensFlare postprocessing pass created by @ektogamat and @N8python.

https://github.com/N8python/nektoFlare

@ektogamat
Copy link

Thanks @kitaedesigns . This one is very performance oriented. It is not relying on raycasters to detect occlusion. Support more than a 100 instances without changing the fps

@shotamatsuda
Copy link

shotamatsuda commented Feb 14, 2025

Hello! I recently created a lens flare effect based on the article mentioned, although it lacks starburst and anamorphism.
Source: https://github.com/takram-design-engineering/three-geospatial/blob/main/packages/effects/src/LensFlareEffect.ts
Demo: https://takram-design-engineering.github.io/three-geospatial/?path=/story/effects-lens-flare--basic

I’d happy to contribute if it’s relevant to this issue and aligns with your performance and feature goals.

@ektogamat
Copy link

Fantastic work @shotamatsuda !!! Congratulations!

@vanruesc
Copy link
Member Author

vanruesc commented Feb 14, 2025

That looks great 👍

@shotamatsuda Feel free to send a PR for v6 since it's already in that format. We can port it to v7 later.

@shotamatsuda
Copy link

Got it. It’ll take some time to refactor and bring it in line with the other codes, but I’ll be sure to make a PR for this. (Glad because I was looking for a good place to integrate a pure post-processing effect.) 🌟

@vanruesc
Copy link
Member Author

vanruesc commented Feb 15, 2025

@shotamatsuda FYI: please only create a new v6 manual demo for testing purposes. The older v6 demos are obsolete.

(Background info: #324 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants