Doc Blocks #62
Merged
Doc Blocks #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polished Doc Blocks behaviors and props: * Added `showLink` to control "Open in new tab" button * Added JSDoc for props so Docs-addon can show them in Props Table * Changed the defaults for more ergonomic ones * Added Docs page for Design Doc Blocks I believe these changes improve both UX(DX) and maintainability.
It was so hard to add/modify/reuse the Wrapper component due to its code highly coupled with Storybook's APIs. This change allos us to render the Wrapper anywhere, includes in Docs and in stories.
Set a story ID then the Block renders based on the story's parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #61
Added Doc Blocks for each embed types.
[ ] linkJust write[Text](url)🤣designparameterPreview
https://storybook-addon-designs-git-feature-doc-blocks.pocka.vercel.app/?path=/docs/docs-advanced-usage--embed-multiple-designs#doc-blocks