Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srcSet not converted to srcset #18

Closed
SimenB opened this issue Dec 8, 2016 · 3 comments · Fixed by #308
Closed

srcSet not converted to srcset #18

SimenB opened this issue Dec 8, 2016 · 3 comments · Fixed by #308

Comments

@SimenB
Copy link

SimenB commented Dec 8, 2016

This works correctly in preact proper

@developit
Copy link
Member

Good catch! Open to a PR, or I can do it whenever I get a chance. I'd like to add an ATTR_MAP mapping like:

const ATTR_MAP = {
  'srcSet': 'srcset'
};

Perhaps the keys on the left could be lowercase and we'd compare the lowercase'd JSX attribute names.

@SimenB
Copy link
Author

SimenB commented Dec 9, 2016

Can't we do toLowerCase on everything that's passed onto DOM nodes?

@developit
Copy link
Member

developit commented Dec 9, 2016

nah, SVG attributes are case-sensitive (viewBox). Though maybe it's easier to special-case that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants