Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start module should start server if user does not #133

Closed
jasonkuhrt opened this issue Dec 6, 2019 · 1 comment · Fixed by #142
Closed

start module should start server if user does not #133

jasonkuhrt opened this issue Dec 6, 2019 · 1 comment · Fixed by #142
Labels
type/improve Something existing is made better, does not affect the interface (example: better error message)

Comments

@jasonkuhrt
Copy link
Member

Currently the presence of an app module causes pumpkins to not scaffold a default one wherein the server is started.

A more gradual approach and module presence for server auto-start would be reflecting on how the API has been used. If server start has been called, then don't. If it has, then do.

Furthermore, it would be nice if this part of the API could literally be hidden from the user under normal circumstances.
@jasonkuhrt jasonkuhrt added the type/improve Something existing is made better, does not affect the interface (example: better error message) label Dec 6, 2019
@jasonkuhrt
Copy link
Member Author

Added to sprint

This was referenced Dec 8, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/improve Something existing is made better, does not affect the interface (example: better error message)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: conditional server start api prisma-labs/graphql-framework-experiment
1 participant
@jasonkuhrt