Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply custom server #368

Closed
jasonkuhrt opened this issue Feb 4, 2020 · 0 comments · Fixed by #382
Closed

Supply custom server #368

jasonkuhrt opened this issue Feb 4, 2020 · 0 comments · Fixed by #382
Assignees
Labels
scope/server Related to the server component type/feat Add a new capability or enhance an existing one

Comments

@jasonkuhrt
Copy link
Member

Perceived Problem

  • there is no way to interop with servers other than express

Ideas / Proposed Solution(s)

  • accept return value from function
  • function must return an object with
    • a property to support add to context calls
    • a property for start
    • a property for stop
  • treat as escape hatch, user should have to opt into this
    • log a warning in dev, fatal in prod
    • opt in via settings.change({ escapeHatches: { customServer: true } }) ??

Related Issues

@jasonkuhrt jasonkuhrt added type/feat Add a new capability or enhance an existing one scope/server Related to the server component labels Feb 4, 2020
@Weakky Weakky mentioned this issue Feb 10, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/server Related to the server component type/feat Add a new capability or enhance an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants