Force plugins to be explicitely enabled

[Weakky]

Description

Right now, plugins are enabled by default as soon as they're in the dependencies of the package.json.

We should investigate ways to enable them only if they were explicitely enabled in some configs somewhere.

Notes

• We probably need some config files to handle this. Right now, the config is handled as an API, which would force the CLI to always run the whole app to get the config. Separating the config into a "standalone" config file (eg: nexus.config.ts) would make reading the config much easier/faster/safer

[Weakky]

Update

After discussing that topic with @jasonkuhrt, we ended up with the following API:

Enable nexus-prisma-plugin

import { plugins } from 'nexus-future'
import nexusPluginPrisma from 'nexus-plugin-prisma'

plugins.use(nexusPluginPrisma({ /* optional configuration */ }))

Enable Nexus Schema built-in plugins

import { plugins } from 'nexus-future'

plugins.use(plugins.builtins.nullabilityGuard, ...)

Local plugin:

import { plugins } from 'nexus-future'

plugins.use((p) => {
 /* ... */
})

This API has several benefits:

• It makes it possible to configure plugins
• Plugins are no longer identified by their names. Therefore, it's now possible to add nexus built-ins plugins (null and authorize plugins). It's also possible for the user to create its own plugin locally without having to publish one
• Furthermore, it would allow for our core to abstract some of its part as plugins. One example is server.custom(). We want for the plugins to be able to contribute custom servers (eg: nexus-plugin-apollo-server). If plugins are able to contribute custom servers, server.custom could simply become a nice abstraction over the creation of a plugin to contribute a custom server.

Notes

• If we ever want to bring back implicit opt-in, they we should continue to force plugin packages to default export their plugin. If not, then plugins should now be able to export plugins however they want. eg: import { nexusPluginPrisma } from 'nexus-plugin-prisma'

[jasonkuhrt]

@Weakky Thanks for capturing these notes. I still have reservations about the functional things we would be losing. I'll try to write them up soon. Maybe some of the losses can be recouped. I'm not sure this API actually has all the touted benefits we think. There is a subjective argument to be sure, but I want to partition the objective from subjective so we can better appraise the tradeoffs.

[jasonkuhrt]

#514

[jasonkuhrt]

Enable Nexus Schema built-in plugins

But for that, I think we should:

settings.change({
  schema: {
    // options here for builtin schema component plugins
    // user does not even know they are builtin schema component plugins
  }
})

We have an existing system. If we think it's good, and we think a schema plugin is good enough to bundle, then I think we should merge them.

[jasonkuhrt]

Resolved by graphql-nexus/nexus@b0704dc