Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not force consumer to deal with @types/pino #808

Closed
jasonkuhrt opened this issue May 6, 2020 · 0 comments · Fixed by jasonkuhrt/floggy#6
Closed

Do not force consumer to deal with @types/pino #808

jasonkuhrt opened this issue May 6, 2020 · 0 comments · Fixed by jasonkuhrt/floggy#6
Labels
component/logger Related to the @nexus/logger package type/bug Something is not working the way it should

Comments

@jasonkuhrt
Copy link
Member

What
@jasonkuhrt jasonkuhrt added type/bug Something is not working the way it should component/logger Related to the @nexus/logger package labels May 6, 2020
This was referenced May 9, 2020
Closed
Merged
jasonkuhrt referenced this issue in jasonkuhrt/floggy May 9, 2020
fix: no force pino types dep (#6)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
654a2e9 
closes graphql-nexus/nexus#808
closes graphql-nexus/nexus#832

This also does a refactor wherein pino is no longer used. Although pino was used for performance reasons the numerous hacks to get it integrated actually mean the immediate result might be better performance (no benchmarks to back this up).

The refactor's primary goal was however to simplify the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/logger Related to the @nexus/logger package type/bug Something is not working the way it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: no force pino types dep jasonkuhrt/floggy
1 participant
@jasonkuhrt