Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with non-serializable plugin settings #817

Closed
jasonkuhrt opened this issue May 7, 2020 · 0 comments · Fixed by #819
Closed

Work with non-serializable plugin settings #817

jasonkuhrt opened this issue May 7, 2020 · 0 comments · Fixed by #819
Labels
scope/plugins type/bug Something is not working the way it should

Comments

@jasonkuhrt
Copy link
Member

Description

  • Change backingTypesMap to mapping graphql-nexus/nexus#782 (comment)
  • plugin settings can contain non-serializable data
  • like functions or objects with circular references
  • when we refactored the reflection system one of the things we did was make it safer by never running the app in the main cli process. So for example an infinite loop or process exit within the user's app would not bring down the main cli process
  • however reflecting on used plugins this way (aka. gathering used plugin manifests) results in the settings of those plugins needing to be serializable
  • and that is not something we intended
  • the only solution after discussion with @Weakky is that we need to reflect on used plugins in process.
  • this exposes the main cli process to the above-mentioned risks
  • dealing with those risks will be treated as a new feature

CC @kristoferma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/plugins type/bug Something is not working the way it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant