New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular deps from codebase #853

Open

jasonkuhrt opened this issue May 14, 2020 · 0 comments

Labels

Member

jasonkuhrt commented May 14, 2020

What

When we investigated using rollup in tree-shake bundle step #119 it told us it discovered circular dependencies in Nexus
We should remove them
Considering this an improvement because of its affect on bundling which is user facing

Why

Usually means more complexity for us as developers to understand the codebase
Not representable in CommonJS so false sense of security in ES modules in TS, can lead to runtime bugs that only occur after transpilation
Makes bundling harder if not impossible, for example rollup tries to inline all code into a single closure.

How

use https://github.com/pahen/madge
We should add a test step that ensures we introduce no new circular deps

jasonkuhrt added the type/improve label

jasonkuhrt mentioned this issue

tree-shake bundle step #119

Closed

12 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment