Skip to content

Commit 0321dc4

Browse files
authoredJul 6, 2020
makefile: fix lint task to run when binary is not found locally (#3)
The makefile task `make lint` did not work if the `golangci-lint` binary is not found locally on the machine. This fixes the run command for `docker` builds as well as upgrade to latest since issues were found in the older version. Signed-off-by: Steve Sloka <[email protected]>
1 parent 9e3f2f7 commit 0321dc4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎Makefile

+4-4
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ vet: ## Run go vet against code
6060
lint: ## Run linters
6161
lint:
6262
@if command -v golangci-lint > /dev/null 2>&1 ; then \
63-
golangci-lint run --exclude-use-default=false ; \
63+
golangci-lint run -v --exclude-use-default=false ; \
6464
else \
65-
$(DOCKER) run \
65+
docker run \
6666
--rm \
6767
--volume $$(pwd):/app \
6868
--workdir /app \
6969
--env GO111MODULE \
70-
golangci/golangci-lint:v1.23.7 \
71-
golangci-lint run --exclude-use-default=false ; \
70+
golangci/golangci-lint:v1.28.1 \
71+
golangci-lint run -v --exclude-use-default=false ; \
7272
fi
7373

7474
.PHONY: docker-build

0 commit comments

Comments
 (0)
Please sign in to comment.