fix(troika-3d-ui): update children when first exiting clip rect

lojjic · lojjic · commit 294f34121e1d · 2020-03-13T14:49:36.000-06:00
The optimization was skipping child updates when going from visible to
fully clipped, which sometimes would leave children stuck in their last
visible state.
diff --git a/packages/troika-3d-ui/src/facade/UIBlock3DFacade.js b/packages/troika-3d-ui/src/facade/UIBlock3DFacade.js
@@ -53,7 +53,8 @@ class UIBlock3DFacade extends Group3DFacade {
    * TODO this doesn't work so well when descendants are absolutely positioned or overflow outside our bounds
    */
   updateChildren(children) {
-    if (!this.isFullyClipped) {
+    if (!this.isFullyClipped || !this._wasFullyClipped) {
+      this._wasFullyClipped = this.isFullyClipped
       super.updateChildren(children)
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ class UIBlock3DFacade extends Group3DFacade {`
`53`	`53`	`* TODO this doesn't work so well when descendants are absolutely positioned or overflow outside our bounds`
`54`	`54`	`*/`
`55`	`55`	`updateChildren(children) {`
`56`		`- if (!this.isFullyClipped) {`
	`56`	`+ if (!this.isFullyClipped \|\| !this._wasFullyClipped) {`
	`57`	`+ this._wasFullyClipped = this.isFullyClipped`
`57`	`58`	`super.updateChildren(children)`
`58`	`59`	`}`
`59`	`60`	`}`