Skip to content

Commit dba914d

Browse files
MrCloudSecMrCloudSec
authored
fix(aws): remove cloudwatch_log_group_no_critical_pii_in_logs check (#5735)
1 parent f8e0db4 commit dba914d

File tree

13 files changed

+2
-1162
lines changed

13 files changed

+2
-1162
lines changed

‎Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ LABEL maintainer="https://github.com/prowler-cloud/prowler"
44

55
# Update system dependencies and install essential tools
66
#hadolint ignore=DL3018
7-
RUN apk --no-cache upgrade && apk --no-cache add curl git g++
7+
RUN apk --no-cache upgrade && apk --no-cache add curl git
88

99
# Create non-root user
1010
RUN mkdir -p /home/prowler && \

‎docs/tutorials/configuration_file.md

-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ The following list includes all the AWS checks with configurable variables that
3030
| `cloudtrail_threat_detection_privilege_escalation` | `threat_detection_privilege_escalation_entropy` | Integer |
3131
| `cloudtrail_threat_detection_privilege_escalation` | `threat_detection_privilege_escalation_minutes` | Integer |
3232
| `cloudwatch_log_group_no_secrets_in_logs` | `secrets_ignore_patterns` | List of Strings |
33-
| `cloudwatch_log_group_no_critical_pii_in_logs` | `critical_pii_entities` | List of Strings |
34-
| `cloudwatch_log_group_no_critical_pii_in_logs` | `pii_language` | String |
3533
| `cloudwatch_log_group_retention_policy_specific_days_enabled` | `log_group_retention_days` | Integer |
3634
| `codebuild_project_no_secrets_in_variables` | `excluded_sensitive_environment_variables` | List of Strings |
3735
| `codebuild_project_no_secrets_in_variables` | `secrets_ignore_patterns` | List of Strings |

‎poetry.lock

+1-676
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎prowler/config/config.yaml

-25
Original file line numberDiff line numberDiff line change
@@ -72,31 +72,6 @@ aws:
7272
# AWS Cloudwatch Configuration
7373
# aws.cloudwatch_log_group_retention_policy_specific_days_enabled --> by default is 365 days
7474
log_group_retention_days: 365
75-
# aws.cloudwatch_log_group_no_critical_pii_in_logs --> see all available entities in https://microsoft.github.io/presidio/supported_entities/
76-
critical_pii_entities : [
77-
"CREDIT_CARD", # Credit card numbers are highly sensitive financial information.
78-
"CRYPTO", # Crypto wallet numbers (e.g., Bitcoin addresses) can give access to cryptocurrency.
79-
"IBAN_CODE", # International Bank Account Numbers are critical financial information.
80-
"US_BANK_NUMBER", # US bank account numbers are sensitive and should be protected.
81-
"US_SSN", # US Social Security Numbers are critical PII used for identity verification.
82-
"US_PASSPORT", # US passport numbers can be used for identity theft.
83-
"US_ITIN", # US Individual Taxpayer Identification Numbers are sensitive personal identifiers.
84-
#"UK_NHS", # UK NHS numbers can be used to access medical records and other private information.
85-
#"ES_NIF", # Spanish NIF (Personal tax ID) is critical for identification and tax purposes.
86-
#"ES_NIE", # Spanish NIE (Foreigners ID card) is a critical identifier for foreign residents.
87-
#"IT_FISCAL_CODE", # Italian personal identification code is sensitive PII for tax and legal purposes.
88-
#"IT_PASSPORT", # Italian passport numbers are critical PII.
89-
#"IT_IDENTITY_CARD", # Italian identity card numbers are critical for personal identification.
90-
#"PL_PESEL", # Polish PESEL numbers are sensitive personal identifiers.
91-
#"SG_NRIC_FIN", # Singapore National Registration Identification Card is critical PII.
92-
#"AU_ABN", # Australian Business Numbers are critical for business identification.
93-
#"AU_TFN", # Australian Tax File Numbers are sensitive and used for taxation purposes.
94-
#"AU_MEDICARE", # Australian Medicare numbers are sensitive medical identifiers.
95-
#"IN_PAN", # Indian Permanent Account Numbers are critical for tax purposes and identity.
96-
#"IN_AADHAAR", # Indian Aadhaar numbers are highly sensitive and serve as a universal identity number.
97-
#"FI_PERSONAL_IDENTITY_CODE" # Finnish Personal Identity Code is sensitive PII for personal identification.
98-
]
99-
pii_language: "en" # Language for recognizing PII entities
10075

10176
# AWS AppStream Session Configuration
10277
# aws.appstream_fleet_session_idle_disconnect_timeout

‎prowler/providers/aws/services/cloudwatch/cloudwatch_log_group_no_critical_pii_in_logs/__init__.py

Whitespace-only changes.

‎prowler/providers/aws/services/cloudwatch/cloudwatch_log_group_no_critical_pii_in_logs/cloudwatch_log_group_no_critical_pii_in_logs.metadata.json

-32
This file was deleted.

‎prowler/providers/aws/services/cloudwatch/cloudwatch_log_group_no_critical_pii_in_logs/cloudwatch_log_group_no_critical_pii_in_logs.py

-147
This file was deleted.

‎prowler/providers/aws/services/cloudwatch/cloudwatch_service.py

-2
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ def __init__(self, provider):
9393
if (
9494
"cloudwatch_log_group_no_secrets_in_logs"
9595
in provider.audit_metadata.expected_checks
96-
or "cloudwatch_log_group_no_critical_pii_in_logs"
97-
in provider.audit_metadata.expected_checks
9896
):
9997
self.events_per_log_group_threshold = (
10098
1000 # The threshold for number of events to return per log group.

‎pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ microsoft-kiota-abstractions = "1.3.3"
6262
msgraph-sdk = "1.8.0"
6363
numpy = "2.0.2"
6464
pandas = "2.2.3"
65-
presidio-analyzer = "2.2.355"
6665
py-ocsf-models = "0.2.0"
6766
pydantic = "1.10.18"
6867
python = ">=3.9,<3.13"

‎tests/config/config_test.py

-20
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,6 @@ def mock_prowler_get_latest_release(_, **kwargs):
3333
"ec2_allowed_instance_owners": ["amazon-elb"],
3434
"trusted_account_ids": [],
3535
"log_group_retention_days": 365,
36-
"critical_pii_entities": [
37-
"CREDIT_CARD", # Credit card numbers are highly sensitive financial information.
38-
"CRYPTO", # Crypto wallet numbers (e.g., Bitcoin addresses) can give access to cryptocurrency.
39-
"IBAN_CODE", # International Bank Account Numbers are critical financial information.
40-
"US_BANK_NUMBER", # US bank account numbers are sensitive and should be protected.
41-
"US_SSN", # US Social Security Numbers are critical PII used for identity verification.
42-
"US_PASSPORT", # US passport numbers can be used for identity theft.
43-
"US_ITIN", # US Individual Taxpayer Identification Numbers are sensitive personal identifiers.
44-
],
45-
"pii_language": "en", # Language for recognizing PII entities
4636
"max_idle_disconnect_timeout_in_seconds": 600,
4737
"max_disconnect_timeout_in_seconds": 300,
4838
"max_session_duration_seconds": 36000,
@@ -107,16 +97,6 @@ def mock_prowler_get_latest_release(_, **kwargs):
10797
"fargate_windows_latest_version": "1.0.0",
10898
"trusted_account_ids": [],
10999
"log_group_retention_days": 365,
110-
"critical_pii_entities": [
111-
"CREDIT_CARD", # Credit card numbers are highly sensitive financial information.
112-
"CRYPTO", # Crypto wallet numbers (e.g., Bitcoin addresses) can give access to cryptocurrency.
113-
"IBAN_CODE", # International Bank Account Numbers are critical financial information.
114-
"US_BANK_NUMBER", # US bank account numbers are sensitive and should be protected.
115-
"US_SSN", # US Social Security Numbers are critical PII used for identity verification.
116-
"US_PASSPORT", # US passport numbers can be used for identity theft.
117-
"US_ITIN", # US Individual Taxpayer Identification Numbers are sensitive personal identifiers.
118-
],
119-
"pii_language": "en", # Language for recognizing PII entities
120100
"max_idle_disconnect_timeout_in_seconds": 600,
121101
"max_disconnect_timeout_in_seconds": 300,
122102
"max_session_duration_seconds": 36000,

‎tests/config/fixtures/config.yaml

-25
Original file line numberDiff line numberDiff line change
@@ -72,31 +72,6 @@ aws:
7272
# AWS Cloudwatch Configuration
7373
# aws.cloudwatch_log_group_retention_policy_specific_days_enabled --> by default is 365 days
7474
log_group_retention_days: 365
75-
# aws.cloudwatch_log_group_no_critical_pii_in_logs --> see all available entities in https://microsoft.github.io/presidio/supported_entities/
76-
critical_pii_entities : [
77-
"CREDIT_CARD", # Credit card numbers are highly sensitive financial information.
78-
"CRYPTO", # Crypto wallet numbers (e.g., Bitcoin addresses) can give access to cryptocurrency.
79-
"IBAN_CODE", # International Bank Account Numbers are critical financial information.
80-
"US_BANK_NUMBER", # US bank account numbers are sensitive and should be protected.
81-
"US_SSN", # US Social Security Numbers are critical PII used for identity verification.
82-
"US_PASSPORT", # US passport numbers can be used for identity theft.
83-
"US_ITIN", # US Individual Taxpayer Identification Numbers are sensitive personal identifiers.
84-
#"UK_NHS", # UK NHS numbers can be used to access medical records and other private information.
85-
#"ES_NIF", # Spanish NIF (Personal tax ID) is critical for identification and tax purposes.
86-
#"ES_NIE", # Spanish NIE (Foreigners ID card) is a critical identifier for foreign residents.
87-
#"IT_FISCAL_CODE", # Italian personal identification code is sensitive PII for tax and legal purposes.
88-
#"IT_PASSPORT", # Italian passport numbers are critical PII.
89-
#"IT_IDENTITY_CARD", # Italian identity card numbers are critical for personal identification.
90-
#"PL_PESEL", # Polish PESEL numbers are sensitive personal identifiers.
91-
#"SG_NRIC_FIN", # Singapore National Registration Identification Card is critical PII.
92-
#"AU_ABN", # Australian Business Numbers are critical for business identification.
93-
#"AU_TFN", # Australian Tax File Numbers are sensitive and used for taxation purposes.
94-
#"AU_MEDICARE", # Australian Medicare numbers are sensitive medical identifiers.
95-
#"IN_PAN", # Indian Permanent Account Numbers are critical for tax purposes and identity.
96-
#"IN_AADHAAR", # Indian Aadhaar numbers are highly sensitive and serve as a universal identity number.
97-
#"FI_PERSONAL_IDENTITY_CODE" # Finnish Personal Identity Code is sensitive PII for personal identification.
98-
]
99-
pii_language: "en" # Language for recognizing PII entities
10075

10176
# AWS AppStream Session Configuration
10277
# aws.appstream_fleet_session_idle_disconnect_timeout

0 commit comments

Comments
 (0)