nknob.c: error: implicit declaration gtk_tooltip_set_text

[papoteur-mga]

I try to build drmr in Mageia repository.
I get this error, with GCC 14:

/builddir/build/BUILD/drumrox-3.3.0/nknob.c: In function 'tooltip_callback':
/builddir/build/BUILD/drumrox-3.3.0/nknob.c:150:5: error: implicit declaration of function 'gtk_tooltip_set_text'; did you mean 'atk_text_get_text'? [-Wimplicit-function-declaration]
150 | gtk_tooltip_set_text(tooltip,buf);
| ^~~~~~~~~~~~~~~~~~~~
| atk_text_get_text
gmake[2]: *** [CMakeFiles/drumrox_ui.dir/build.make:149: CMakeFiles/drumrox_ui.dir/nknob.c.o] Error 1

This is with 3.3.0 release.

[psemiletov]

That's why I don't like GTK - there changes even old API's. Please try my new drum machine plugin instead - https://github.com/psemiletov/drumlabooh

[papoteur-mga]

Thanks for your quick reply.
I found that this patch can solve the compilation problem:

From 0cb62de9f041b6a80a276a5c38b2c869c38f9cf2 Mon Sep 17 00:00:00 2001
From: Papoteur <[email protected]>
Date: Thu, 12 Sep 2024 17:32:29 +0200
Subject: [PATCH] drumrox fix implicit declaration

---
 nknob.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nknob.c b/nknob.c
index 71d9661..d5e8d79 100644
--- a/nknob.c
+++ b/nknob.c
@@ -35,6 +35,7 @@
 #include <stdlib.h>
 #include <gtk/gtkmain.h>
 #include <gtk/gtksignal.h>
+#include <gtk/gtktooltip.h>
 #include "nknob.h"
 
 #define SCROLL_DELAY_LENGTH     100
-- 
2.41.1

Packaging of drumlabooh is another business, we don't have packages for Juce nor speex_resampler_c++

[psemiletov]

Thank you for the patch, fixed - https://github.com/psemiletov/drumrox/releases/tag/3.3.1
And about Drumlabooh - it works as the static build, with speex_resampler included at the source tree, and JUCE is downloaded at the build time. For example, that how looks the AUR package for Drumlabooh: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=drumlabooh

[papoteur-mga]

Thanks for the quick release.
In our distribution, we have at least these rules:

• no binaries are included as source; all should be built on distro side;
• network access during the build is cut; we should have the same sources when building again at any time;
• libraries are packaged independently; this is not an absolute rule; this is to allow a better management of security concerns.

AUR has relaxed rules.
speex_resampler could be OK, but we should have juce as separate package.

[papoteur-mga]

Closing as completed