New styleguide

Summary: The old one wasn't working right and confusing. This one is simpler and works..

Test Plan: N/A

Reviewers: O1 The Ori, brookea

Reviewed By: O1 The Ori, brookea

Subscribers: brookea

Tags: #zorp

Differential Revision: http://phabricator.purduesigbots.com/D85

Author: edjubuh

.clang-format

@@ -1,49 +1,15 @@
-BasedOnStyle: LLVM
-AlignAfterOpenBracket: Align
-# AlignEscapedNewlines: Right
-AlignOperands: true
-AlignTrailingComments: true
-AllowAllParametersOfDeclarationOnNextLine: false
-AllowShortBlocksOnASingleLine: false
-AllowShortCaseLabelsOnASingleLine: false
-AllowShortFunctionsOnASingleLine: Empty
-AllowShortIfStatementsOnASingleLine: true
-AllowShortLoopsOnASingleLine: true
-AlwaysBreakAfterReturnType: None
-AlwaysBreakBeforeMultilineStrings: false
-AlwaysBreakTemplateDeclarations: false
-BinPackArguments: true
-BinPackParameters: false
-BreakBeforeBraces: Attach
-BreakBeforeBinaryOperators: None
-# BreakBeforeInheritanceComma: false
-BreakBeforeTernaryOperators: true
-# BreakStringLiterals: true
-ColumnLimit: 120
-# CompactNamespaces: False
-ConstructorInitializerAllOnOneLineOrOnePerLine: false
-Cpp11BracedListStyle: false
-DerivePointerAlignment: false
-# FixNamespaceComments: true
-IndentCaseLabels: false
-IndentWidth: 8
-IndentWrappedFunctionNames: true
+BasedOnStyle: Google
+TabWidth: 2
 Language: Cpp
-NamespaceIndentation: Inner
-SortIncludes: true
-# SortUsingDeclarations: true
-SpaceAfterCStyleCast: false
-# SpaceAfterTemplateKeyword: false
-SpaceBeforeAssignmentOperators: true
-SpaceBeforeParens: ControlStatements
-SpaceInEmptyParentheses: false
-SpacesBeforeTrailingComments: 2
-SpacesInAngles: false
-SpacesInCStyleCastParentheses: false
-SpacesInContainerLiterals: false
-SpacesInParentheses: false
-SpacesInSquareBrackets: false
-Standard: Cpp11
 UseTab: ForIndentation
+ColumnLimit: 120
+Standard: Cpp11
+DerivePointerAlignment: false
 PointerAlignment: Left
+FixNamespaceComments: true
+ReflowComments: true
+SortIncludes: true
 AccessModifierOffset: 0
+AllowShortBlocksOnASingleLine: false
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: Empty

STYLEGUIDE.md

@@ -24,7 +24,9 @@ typedef struct ll_node_s {
 	struct ll_node_s* next;
 } ll_node_s_t;
 
-typedef struct { ll_node_s_t* head; } linked_list_s_t;
+typedef struct {
+	ll_node_s_t* head;
+} linked_list_s_t;
 
 /**
  * \brief Initialize a linked list node storing an arbitrary function pointer

include/common/linkedlist.h

@@ -13,10 +13,10 @@
 
 #pragma once
 
-#include "kapi.h"
 #include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
+#include "kapi.h"
 
 struct set {
 	uint32_t* arr;

include/common/set.h

@@ -34,11 +34,11 @@ extern "C" {
 #define kprint(str) kprintf("%s", str)
 
 #ifndef PROS_RELEASING
-#define kassert(cond)                                                                                                  \
-	do {                                                                                                           \
-		if (!(cond)) {                                                                                         \
-			kprint("Assertion failed: " #cond);                                                            \
-		}                                                                                                      \
+#define kassert(cond)                     \
+	do {                                    \
+		if (!(cond)) {                        \
+			kprint("Assertion failed: " #cond); \
+		}                                     \
 	} while (0)
 #else
 #define kassert(cond)
@@ -73,13 +73,8 @@ int32_t rtos_resume_all(void);
  * Creates a task using statically allocated buffers. All tasks used by the PROS
  * system must use statically allocated buffers.
  */
-task_t task_create_static(task_fn_t task_code,
-                          void* const param,
-                          uint32_t priority,
-                          const size_t stack_size,
-                          const char* const name,
-                          task_stack_t* const stack_buffer,
-                          static_task_s_t* const task_buffer);
+task_t task_create_static(task_fn_t task_code, void* const param, uint32_t priority, const size_t stack_size,
+                          const char* const name, task_stack_t* const stack_buffer, static_task_s_t* const task_buffer);
 
 /**
  * Creates a statically allocated mutex. See the documentation in api.h for mutex_create().
@@ -100,8 +95,8 @@ sem_t sem_create_static(uint32_t uxMaxCount, uint32_t uxInitialCount, static_sem
  *
  * All FreeRTOS primitives must be created statically if they are required for operation of the kernel.
  */
-queue_t
-    queue_create_static(uint32_t length, uint32_t item_size, uint8_t* storage_buffer, static_queue_s_t* queue_buffer);
+queue_t queue_create_static(uint32_t length, uint32_t item_size, uint8_t* storage_buffer,
+                            static_queue_s_t* queue_buffer);
 
 /**
  * \brief Display a non-fatal error to the built-in LCD/touch screen.