Skip to content

Commit c4977ea

Browse files
authored
Fix setter properties in Data (#4686)
* fix * update
1 parent 9761ccf commit c4977ea

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
2424
- Added `CHANGELOG.md` ([#4581](https://github.com/pyg-team/pytorch_geometric/pull/4581))
2525
### Changed
2626
- Math support in Markdown ([#4683](https://github.com/pyg-team/pytorch_geometric/pull/4683))
27-
- Allow for `setter` properties in `Data` and `HeteroData` ([#4682](https://github.com/pyg-team/pytorch_geometric/pull/4682))
27+
- Allow for `setter` properties in `Data` ([#4682](https://github.com/pyg-team/pytorch_geometric/pull/4682), [#4686](https://github.com/pyg-team/pytorch_geometric/pull/4686))
2828
- Allow for optional `edge_weight` in `GCN2Conv` ([#4670](https://github.com/pyg-team/pytorch_geometric/pull/4670))
2929
- Fixed the interplay between `TUDataset` and `pre_transform` that modify node features ([#4669](https://github.com/pyg-team/pytorch_geometric/pull/4669))
3030
- Make use of the `pyg_sphinx_theme` documentation template ([#4664](https://github.com/pyg-team/pyg-lib/pull/4664), [#4667](https://github.com/pyg-team/pyg-lib/pull/4667))

torch_geometric/data/data.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -376,10 +376,10 @@ def __getattr__(self, key: str) -> Any:
376376

377377
def __setattr__(self, key: str, value: Any):
378378
propobj = getattr(self.__class__, key, None)
379-
if propobj is None or propobj.fset is None:
380-
setattr(self._store, key, value)
381-
else:
379+
if propobj is not None and getattr(propobj, 'fset', None) is not None:
382380
propobj.fset(self, value)
381+
else:
382+
setattr(self._store, key, value)
383383

384384
def __delattr__(self, key: str):
385385
delattr(self._store, key)

0 commit comments

Comments
 (0)