Skip to content

Commit 84c197d

Browse files
github-actions[bot]Pierre-Sassoulasjacobtylerwalls
authored
[Backport maintenance/2.17.x] Add regression test for #7506 (#8531)
* Add regression test for #7506 (#8432) (cherry picked from commit 1fa16c2) --------- Co-authored-by: Pierre Sassoulas <[email protected]> Co-authored-by: Jacob Walls <[email protected]>
1 parent 574edc3 commit 84c197d

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Fix ``unused-import`` false positive for usage of ``six.with_metaclass``.
2+
3+
Closes #7506

requirements_test.txt

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ contributors-txt>=1.0.0
66
pytest-cov~=4.0
77
pytest-profiling~=1.7
88
pytest-xdist~=3.2
9+
six
910
# Type packages for mypy
1011
types-pkg_resources==0.1.3
1112
tox>=3

tests/functional/u/unused/unused_import.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
# +1:[unused-import,unused-import]
1111
from collections import deque, OrderedDict, Counter
1212
import re, html.parser # [unused-import]
13+
import six
1314

1415
DATA = Counter()
1516
# pylint: disable=self-assigning-variable
@@ -98,8 +99,10 @@ def blop(self):
9899
import zoneinfo
99100

100101

101-
class WithMetaclass(metaclass=ABCMeta):
102-
pass
102+
class WithMetaclass(six.with_metaclass(ABCMeta)):
103+
"""Regression test for https://github.com/PyCQA/pylint/issues/7506.
104+
105+
Requires six."""
103106

104107

105108
# Regression test for https://github.com/PyCQA/pylint/issues/3765

tests/functional/u/unused/unused_import.txt

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ unused-import:8:0:8:21::Unused flags imported from sys:UNDEFINED
66
unused-import:11:0:11:51::Unused OrderedDict imported from collections:UNDEFINED
77
unused-import:11:0:11:51::Unused deque imported from collections:UNDEFINED
88
unused-import:12:0:12:22::Unused import re:UNDEFINED
9-
unused-import:16:0:16:40::Unused SomeOtherName imported from fake:UNDEFINED
10-
unused-import:53:0:53:9::Unused import os:UNDEFINED
11-
unused-import:88:4:88:19::Unused import unittest:UNDEFINED
12-
unused-import:90:4:90:15::Unused import uuid:UNDEFINED
13-
unused-import:92:4:92:19::Unused import warnings:UNDEFINED
14-
unused-import:94:4:94:21::Unused import compileall:UNDEFINED
9+
unused-import:17:0:17:40::Unused SomeOtherName imported from fake:UNDEFINED
10+
unused-import:54:0:54:9::Unused import os:UNDEFINED
11+
unused-import:89:4:89:19::Unused import unittest:UNDEFINED
12+
unused-import:91:4:91:15::Unused import uuid:UNDEFINED
13+
unused-import:93:4:93:19::Unused import warnings:UNDEFINED
14+
unused-import:95:4:95:21::Unused import compileall:UNDEFINED

0 commit comments

Comments
 (0)