Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MSVC builds fail because shared_lib_format is not defined #4885

Closed
klayoutmatthias opened this issue Mar 14, 2025 · 1 comment · Fixed by pypa/distutils#342
Closed

[BUG] MSVC builds fail because shared_lib_format is not defined #4885

klayoutmatthias opened this issue Mar 14, 2025 · 1 comment · Fixed by pypa/distutils#342
Labels
bug upstream

Comments

@klayoutmatthias
Copy link

setuptools version

76.0.0

Python version

All

OS

Windows

Additional environment information

No response

Description

_distutils/compilers/C/msvc.py does not define the shared_lib_format attribute. Here is line 260:

static_lib_format = static_lib_format = '%s%s'

It used to be

static_lib_format = shared_lib_format = '%s%s'

but was broken with this commit: 19e9575#diff-f9638b451b134f36d333164e25a77ede338e15822339b99851e4f345a76052c4R259

Expected behavior

shared_lib_format should be available again

How to Reproduce

Perform a build that produces shared objects with MSVC

Output
@klayoutmatthias klayoutmatthias added bug Needs Triage Issues that need to be evaluated for severity and status. labels Mar 14, 2025
@klayoutmatthias klayoutmatthias changed the title [BUG] MSVC builds fail becuase shared_lib_format is not defined [BUG] MSVC builds fail because shared_lib_format is not defined Mar 14, 2025
@klayoutmatthias klayoutmatthias mentioned this issue Mar 14, 2025
Closed
@abravalheri
Copy link
Contributor

"Duplicate" of pypa/distutils#342.
Waiting review of pypa/distutils maintainers.

@abravalheri abravalheri linked a pull request Mar 14, 2025 that will close this issue
Bugfix: MSVC compiler no longer sets shared_lib_format pypa/distutils#342
Merged
@abravalheri abravalheri mentioned this issue Mar 18, 2025
Merged
6 tasks
@abravalheri abravalheri added upstream and removed Needs Triage Issues that need to be evaluated for severity and status. labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: MSVC compiler no longer sets shared_lib_format Avasam/distutils
2 participants
@abravalheri @klayoutmatthias