typing - row_event.py #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhwan-cheon
commented
Aug 28, 2023
•
suhwan-cheon
commented
- row_event.py 파일에 typing 적용하였습니다.
- docstring 및 주석 업데이트 하였습니다.
- 다른 PEP 규정에 맞춰 추가로 수정된 부분이 있습니다.
- python 3.7, 3.9, 3.11 버전 테스트 하였습니다.
Open
| table_map: Dict[int, Any], | ||
| ctl_connection: Any, | ||
| **kwargs: Any | ||
| ) -> None: |
There was a problem hiding this comment.
인자로서 클래스의 인스턴스가 기대되는 경우, 해당 클래스를 type annotation으로 추가해주세요.
실제로 어떤 type이 올 수 있는 경우가 아니라면 Any는 어떤 유용한 정보도 추가로 제공하지 않습니다.
아래 추가해주신 Any에도 해당되는 내역이며 중복 코멘트는 하지 않겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.