Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misclick #2748

Closed
A5rocks opened this issue Aug 10, 2023 · 1 comment
Closed

misclick #2748

A5rocks opened this issue Aug 10, 2023 · 1 comment

Comments

@A5rocks
Copy link
Contributor

A5rocks commented Aug 10, 2023

          The signature in [argonholm/exceptiongroup](https://github.com/agronholm/exceptiongroup/blob/0878b8331a905f18b4d39b24b105b3e514ada65b/src/exceptiongroup/_exceptions.py#L213) is
    def derive(self: Self, __excs: Sequence[_BaseExceptionT_co]) -> Self:

and in typeshed it is

# In reality it is `NonEmptySequence`:
@overload
def derive(self, __excs: Sequence[_ExceptionT]) -> ExceptionGroup[_ExceptionT]: ...
@overload
def derive(self, __excs: Sequence[_BaseExceptionT]) -> BaseExceptionGroup[_BaseExceptionT]: ...

I found agronholm/exceptiongroup#40, python/typeshed#9219, and python/typeshed#9230 and reading those it seems that this should've been resolved?

It might be that disallow_any_generics would flag something further up if you enabled it

Originally posted by @jakkdl in #2733 (comment)

@A5rocks
Copy link
Contributor Author

A5rocks commented Aug 10, 2023

Oops, I was clicking "reference in new issue" to test things out, typed in agromholm/exceptiongroups as the repo and pressed enter, hoping it would work. It didn't :(

@A5rocks A5rocks closed this as completed Aug 10, 2023
@A5rocks A5rocks changed the title The signature in [argonholm/exceptiongroup](https://github.com/agronholm/exceptiongroup/blob/0878b8331a905f18b4d39b24b105b3e514ada65b/src/exceptiongroup/_exceptions.py#L213) is misclick Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant