Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject wbits = 8 #410

Closed
aaugustin opened this issue May 21, 2018 · 2 comments
Closed

Reject wbits = 8 #410

aaugustin opened this issue May 21, 2018 · 2 comments
Labels
bug

Comments

@aaugustin
Copy link
Member

websockets crashes when the remote endpoint requests a window size of 8 bits.

This is a side effect of a change in zlib. It's described here: madler/zlib#171

This isn't an issue in practice because no one requests such a small window size (except autobahn testsuite).
@aaugustin aaugustin added the bug label May 21, 2018
@aaugustin
Copy link
Member Author

The minimum value supported by Python's zlib module changed stealthily from 8 to 9 in python/cpython@0fdf41d

@aaugustin
Copy link
Member Author

Based on madler/zlib#87 (comment), I'm going to ignore this issue and hope for the best (at least until someone complains).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaugustin