gh-93747: Fix Refleak when handling multiple Py_tp_doc slots (gh-93749)

corona10 · web-flow · commit ae1ca74513e7 · 2022-06-13T00:55:01.000+09:00
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -3569,7 +3569,7 @@ PyType_FromMetaclass(PyTypeObject *metaclass, PyObject *module,
                 PyErr_SetString(
                     PyExc_SystemError,
                     "Multiple Py_tp_doc slots are not supported.");
-                return NULL;
+                goto finally;
             }
             if (slot->pfunc == NULL) {
                 type->tp_doc = NULL;

Original file line number	Diff line number	Diff line change
`@@ -3569,7 +3569,7 @@ PyType_FromMetaclass(PyTypeObject metaclass, PyObject module,`
`3569`	`3569`	`PyErr_SetString(`
`3570`	`3570`	`PyExc_SystemError,`
`3571`	`3571`	`"Multiple Py_tp_doc slots are not supported.");`
`3572`		`- return NULL;`
	`3572`	`+ goto finally;`
`3573`	`3573`	`}`
`3574`	`3574`	`if (slot->pfunc == NULL) {`
`3575`	`3575`	`type->tp_doc = NULL;`