Skip to content

LighthouseClient: support heartbeats #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d4l3k opened this issue Apr 25, 2025 · 1 comment
Open

LighthouseClient: support heartbeats #174

d4l3k opened this issue Apr 25, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers lighthouse Lighthouse and quorum related

Comments

@d4l3k
Copy link
Member

d4l3k commented Apr 25, 2025

Right now the bare bones coordination API doesn't support heartbeats (which is a notable oversight 😓). We should either move the heartbeating logic from manager.rs into a wrapper around the lighthouse client or we can do the simple thing for now and expose the heartbeat method on the pyo3 bindings.

https://github.com/pytorch/torchft/blob/main/src/lib.rs#L482-L484

@d4l3k d4l3k added enhancement New feature or request good first issue Good for newcomers lighthouse Lighthouse and quorum related labels Apr 25, 2025
@MattKotzbauer
Copy link

Am currently working on the simpler task of exposing the heartbeat method on pyo3 bindings - will open a PR shortly 🤙.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers lighthouse Lighthouse and quorum related
Projects
None yet
Development

No branches or pull requests

2 participants