-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better specify torch.compile behaviour
on nested function/module
#2858
Comments
torch.compile behaviour
on nested function/module
/assigntome |
@awayzjj Are you still working on this issue? If not I would like to help. Thanks! |
I removed the assighment! You can take it! @ignaciobartol |
I assigned myself to another issue yesterday and still I'm working on it, I apologize for the confusion if you still wanted to work on it. I will check back later today after submitting a PR to see if this one is still available. But thanks!! @awayzjj |
/cc @ezyang Just in the case we could use this to improve the documentation about the best practices on reporting |
/assigntome |
Not sure what you're looking for here. If you torch.compile a function, we will try to recursively inline/compile every function call inside it. If there's a graph break, we will try again for inner frames. There are some other functions to disable this process if needed. |
Yes I think currently this is not explicitly specified in the doc right? |
OK, send a doc patch for this @ignaciobartol, thanks |
@ezyang Yes, sorry I got caught up with other work yesterday. I will work on it later today and submit a PR |
📚 The doc issue
Can we better specify the behavior and eventually the best practices when decorating a function or compiling a module and the effect on the nested modules and nested function call?
https://pytorch.org/tutorials/intermediate/torch_compile_tutorial.html
Suggest a potential alternative/fix
No response
cc @sekyondaMeta @svekars @kit1980 @williamwen42 @msaroufim @ezyang @bdhirsh @anijain2305 @zou3519 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng
The text was updated successfully, but these errors were encountered: