Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Remove Dataprovider from data/ remove ASE dependency #106

Closed
andersx opened this issue Feb 22, 2019 · 3 comments
Closed

Remove Dataprovider from data/ remove ASE dependency #106

andersx opened this issue Feb 22, 2019 · 3 comments

Comments

@andersx
Copy link
Member

andersx commented Feb 22, 2019

As said in title. These are superseeded by the QMLearn interface.

This will also remove the dependency on ASE, as far as I can see.

Any downsides to this @larsbratholm ?

@larsbratholm
Copy link
Collaborator

larsbratholm commented Feb 22, 2019 via email

@andersx
Copy link
Member Author

andersx commented Feb 22, 2019

I'll make a PR to remove the outdated dataprovider and (for now) remove ase then!

@andersx
Copy link
Member Author

andersx commented Mar 2, 2019

Closing this now that PR #108 is accepted!

@andersx andersx closed this as completed Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants