Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev dependency required to actor-init-sparql #116

Closed
gsvarovsky opened this issue Nov 19, 2020 · 3 comments
Closed

Dev dependency required to actor-init-sparql #116

gsvarovsky opened this issue Nov 19, 2020 · 3 comments

Comments

@gsvarovsky
Copy link
Contributor

Working in Typescript, I had to add a devDependency to @comunica/actor-init-sparql so that the typings for Comunica are available and the project compiles.

This is a dev dependency only because node-quadstore-comunica bundles the Comunica code.

@jacoscaz
Copy link
Collaborator

I think the best way to address this is to include the relevant typings within quadstore-comunica by either copying them or crafting them by hand.

Any other solution I was able to come up with would result in having the entire comunica framework as a dependency of quadstore, much as you're experiencing right now, and I feel that would not be a healthy direction.

@jacoscaz
Copy link
Collaborator

@gsvarovsky could you test this with [email protected], which I've just released to NPM with the beta tag?

@gsvarovsky
Copy link
Contributor Author

Fixed in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants