-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyfolio no longer supports pandas < 0.20 #407
Comments
@gusgordon sounds like a pretty big compatibility issue |
CC @richafrank |
@jscotkin Which pandas version is that? The error is pretty confusing, what does |
I installed from git, the pandas dependency is OK but I'm still getting the same error as the OP |
@fpaboim Can you post the exception again, just to make sure? |
Sorry, couldn't reproduce this. I've messed a lot with pip and python installations, and got it to work with pandas 0.18, don't know how the issue started.. |
We fixed the issue :). |
Seems like this is still a bug in python3 pandas <0.19.1. See https://stackoverflow.com/a/42600828/3835466 I'm still getting this issue using latest install of pyfolio in python3. |
Can you post the code to reproduce the issue along with the exception? |
Run in ipython. Throws error with pandas 0.18.1 (zipline default), and pandas 0.22 (pyfolio default, on |
I seem to be getting the same issue, with almost identical code to @cyniphile I'm using one environment with both zipline[v1.1.1] and pyfoli[v0.8.0] (both installed with pip) installed and have pandas[v0.18.1] installed. |
I believe this bug exist when you have pandas < 0.19.2 (incl 0.18.1), and python 3.6 installed. The root problem seems to be this throwing exception (when it should just return a This works if your python is <=3.5, regardless of pandas version FWIW hopefully we could have pandas 0.22 working with zipline soon, then we can all move away from 0.18.1 |
Thanks for figuring this out @AdrianTeng. Is there any work-around you can think of which helps for now? |
@twiecki I've moved back to python 3.5 for now (sadly!) Once zipline is moved to pandas 0.22 I would move back to python 3.6 |
Note that zipline does seem to be working with pandas 0.22. |
Not sure how/why I unassigned @yankees714 |
Pyfolio crashes (see below) on pandas 0.18 (or 0.19). This causes a bit of trouble since Zipline doesn't support pandas > 0.18. Running them in separate environments works.
The crash log below is on current git head. Same notebook works fine with pandas 0.20. I'm guessing it was introduced with merge #395 , which had some datetime updates related to pandas, but could be wrong.
Thank you!
The text was updated successfully, but these errors were encountered: