chore: fix review comments

Author: Naveen Aiathurai

src/indexer/segment_writer.rs

@@ -458,10 +458,7 @@ mod tests {
     use crate::store::{Compressor, StoreReader, StoreWriter};
     use crate::time::format_description::well_known::Rfc3339;
     use crate::time::OffsetDateTime;
-    use crate::tokenizer::{
-        Language, PreTokenizedString, RemoveLongFilter, Stemmer, TextAnalyzer, Token,
-        WhitespaceTokenizer,
-    };
+    use crate::tokenizer::{PreTokenizedString, Token};
     use crate::{
         DateTime, Directory, DocAddress, DocSet, Document, Index, Postings, Term, TERMINATED,
     };
@@ -912,7 +909,6 @@ mod tests {
         assert_eq!(positions, &[4]); //< as opposed to 3 if we had a position length of 1.
     }
 
-    // ISSUE-#2078 - writing and searching shall throw error when the field tokenizer is missing
     #[test]
     fn test_show_error_when_tokenizer_not_registered() {
         let text_field_indexing = TextFieldIndexing::default()
@@ -921,32 +917,23 @@ mod tests {
         let text_options = TextOptions::default()
             .set_indexing_options(text_field_indexing)
             .set_stored();
-        let custom_en_tokenizer = TextAnalyzer::builder(WhitespaceTokenizer::default())
-            .filter(RemoveLongFilter::limit(40))
-            .filter(Stemmer::new(Language::English))
-            .build();
         let mut schema_builder = Schema::builder();
         schema_builder.add_text_field("title", text_options);
         let schema = schema_builder.build();
         let tempdir = TempDir::new().unwrap();
         let tempdir_path = PathBuf::from(tempdir.path());
-        let index = Index::create_in_dir(&tempdir_path, schema).unwrap();
-        index
-            .tokenizers()
-            .register("custom_en", custom_en_tokenizer);
+        Index::create_in_dir(&tempdir_path, schema).unwrap();
         let index = Index::open_in_dir(tempdir_path).unwrap();
         let schema = index.schema();
         let mut index_writer = index.writer(50_000_000).unwrap();
         let title = schema.get_field("title").unwrap();
         let mut document = Document::default();
         document.add_text(title, "The Old Man and the Sea");
         index_writer.add_document(document).unwrap();
-        match index_writer.commit() {
-            Ok(_) => panic!("Commit should have failed"),
-            Err(e) => assert_eq!(
-                e.to_string(),
-                "Schema error: 'Error getting tokenizer for field: title'"
-            ),
-        }
+        let error = index_writer.commit().unwrap_err();
+        assert_eq!(
+            error.to_string(),
+            "Schema error: 'Error getting tokenizer for field: title'"
+        );
     }
 }