enable range query on fast field for u64 compatible types #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1762 +/- ##
==========================================
+ Coverage 94.06% 94.12% +0.05%
==========================================
Files 280 281 +1
Lines 52285 52824 +539
==========================================
+ Hits 49184 49719 +535
- Misses 3101 3105 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PSeitz
force-pushed
the
fastfield_range_query
branch
from
518022c to
ac53335
Compare
fulmicoton
requested review from
ChillFish8
and removed request for
ChillFish8
fulmicoton
reviewed
Jan 6, 2023
fulmicoton
reviewed
Jan 6, 2023
| use crate::core::SegmentReader; | ||
| use crate::error::TantivyError; | ||
| use crate::query::explanation::does_not_match; | ||
| use crate::query::range_query::range_query_ip_fastfield::IPFastFieldRangeWeight; | ||
| use crate::query::{BitSetDocSet, ConstScorer, EnableScoring, Explanation, Query, Scorer, Weight}; | ||
| use crate::schema::{Field, IndexRecordOption, Term, Type}; | ||
| use crate::termdict::{TermDictionary, TermStreamer}; | ||
| use crate::{DocId, Score}; | ||
| use crate::{DateTime, DocId, Score}; | ||
|
|
||
| pub(crate) fn map_bound<TFrom, TTo, Transform: Fn(&TFrom) -> TTo>( | ||
| bound: &Bound<TFrom>, |
There was a problem hiding this comment.
Suggested change
| bound: &Bound<TFrom>, | |
| bound: Bound<TFrom>, |
fulmicoton
approved these changes
Jan 6, 2023
PSeitz
force-pushed
the
fastfield_range_query
branch
from
ac53335 to
e8917be
Compare
shikhar
reviewed
Jan 6, 2023
PSeitz
force-pushed
the
fastfield_range_query
branch
from
e8917be to
c2fa44e
Compare
PSeitz
force-pushed
the
fastfield_range_query
branch
from
c2fa44e to
b91c52a
Compare
This was referenced Jan 13, 2023
Closed
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
…ss#1762) * enable range query on fast field for u64 compatible types * rename, update benches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.