Added support for madvise #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
madvise-support
branch
from
60eccca to
7750494
Compare
fulmicoton
force-pushed
the
madvise-support
branch
from
7750494 to
71e6738
Compare
Cargo.toml
Outdated
| @@ -19,6 +19,7 @@ base64 = "0.21.0" | |||
| byteorder = "1.4.3" | |||
| crc32fast = "1.3.2" | |||
| once_cell = "1.10.0" | |||
| madvise = { version="0.1", optional= true } | |||
There was a problem hiding this comment.
Note that memmap2 has integrated support for madvise(2): https://docs.rs/memmap2/latest/memmap2/struct.Mmap.html#method.advise
There was a problem hiding this comment.
Yes good point, let's use that and remove the feature flag
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2036 +/- ##
==========================================
- Coverage 94.39% 94.38% -0.02%
==========================================
Files 319 319
Lines 59161 59198 +37
==========================================
+ Hits 55846 55874 +28
- Misses 3315 3324 +9
|
fulmicoton
force-pushed
the
madvise-support
branch
from
b4681af to
70b20cd
Compare
fulmicoton
force-pushed
the
madvise-support
branch
from
70b20cd to
2329579
Compare
|
@PSeitz can you have a look? |
PSeitz
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.