Skip to content

Commit d1db816

Browse files
committed
temporany remove windows test due of actions/checkout#1186
Signed-off-by: Gabriele Santomaggio <[email protected]>
1 parent 3bbc832 commit d1db816

File tree

2 files changed

+30
-24
lines changed

2 files changed

+30
-24
lines changed

Diff for: .github/workflows/build_and_test.yml

+25-24
Original file line numberDiff line numberDiff line change
@@ -63,30 +63,31 @@ jobs:
6363
verbose: true # optional (default = false)
6464
env:
6565
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
66-
test-win32:
67-
runs-on: windows-latest
68-
strategy:
69-
matrix:
70-
go: [ '1.22']
71-
steps:
72-
- uses: actions/checkout@v4
73-
- uses: actions/setup-go@v5
74-
id: setup_go
75-
with:
76-
go-version: ${{ matrix.go }}
77-
check-latest: true
78-
- name: Cache installers
79-
uses: actions/cache@v4
80-
with:
81-
# Note: the cache path is relative to the workspace directory
82-
# https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#using-the-cache-action
83-
path: ~/installers
84-
key: ${{ runner.os }}-v0-${{ hashFiles('.ci/versions.json') }}
85-
- name: Install and start RabbitMQ
86-
run: ./.ci/install.ps1
87-
- name: Install GNU make
88-
run: choco install make
89-
- run: make test GO_VERSION=${{ steps.setup_go.outputs.go-version }}
66+
# temporany removed due of https://github.com/actions/checkout/issues/1186
67+
# test-win32:
68+
# runs-on: windows-latest
69+
# strategy:
70+
# matrix:
71+
# go: [ '1.22']
72+
# steps:
73+
# - uses: actions/checkout@v4
74+
# - uses: actions/setup-go@v5
75+
# id: setup_go
76+
# with:
77+
# go-version: ${{ matrix.go }}
78+
# check-latest: true
79+
# - name: Cache installers
80+
# uses: actions/cache@v4
81+
# with:
82+
# # Note: the cache path is relative to the workspace directory
83+
# # https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#using-the-cache-action
84+
# path: ~/installers
85+
# key: ${{ runner.os }}-v0-${{ hashFiles('.ci/versions.json') }}
86+
# - name: Install and start RabbitMQ
87+
# run: ./.ci/install.ps1
88+
# - name: Install GNU make
89+
# run: choco install make
90+
# - run: make test GO_VERSION=${{ steps.setup_go.outputs.go-version }}
9091
publish:
9192
runs-on: ubuntu-latest
9293
needs: [test]

Diff for: pkg/integration_test/stream_integration_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ var _ = Describe("StreamIntegration", func() {
5050
for {
5151
select {
5252
case confirmations := <-confirmationCh:
53+
for i := range confirmations {
54+
Expect(confirmations[i].IsConfirmed()).To(BeTrue())
55+
}
5356
for range confirmations {
5457
count += 1
5558
if count == totalExpected {
@@ -113,6 +116,8 @@ var _ = Describe("StreamIntegration", func() {
113116
Expect(err).ToNot(HaveOccurred())
114117
}
115118

119+
// wait a bit. We don't have confirmation here
120+
116121
// We should receive only 100 messages because Next sends the next chunk
117122
// in the stream. The previously 100 messages should be in a different chunk
118123
By("receiving only new messages")

0 commit comments

Comments
 (0)